8322324: java/foreign/TestStubAllocFailure.java times out while waiting for forked process

[JornVernee]

The issue with this test, and the test of JDK-8322324, seems to be that the forked processes write to stderr/stdout, without this output being read before the process terminates. The buffer might fill up if the output is not being read, which means that the process will stall when writing (see stack trace in JBS issue).

OutputAnalyzer has ways to prevent this by continuously reading from the output streams in separate threads, but because the current code calls Process::waitFor before creating the OutputAnalyzer, we never actually read the written output of the fork, which occasionally results in a stall and subsequent timeout.

The fix proposed by this patch is to use ProcessTools::startProcess, instead of ProcessBuilder::start, which will also start the necessary reader threads, preventing a stall. Incidentally, startProcess also has built-in timeout handling which we can use.

Testing:

• 500 runs of both java/foreign/TestStubAllocFailure.java and java/foreign/critical/TestCriticalUpcall on various Windows x64 hosts (100 iterations was enough to observe the failure twice).
• jdk_foreign suite.

/solves JDK-8322637

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8322324: java/foreign/TestStubAllocFailure.java times out while waiting for forked process (Bug - P2)
• JDK-8322637: java/foreign/critical/TestCriticalUpcall.java timed out (Bug - P4)

Reviewers

• Maurizio Cimadamore (@mcimadamore - Reviewer) ⚠️ Review applies to 2ba2851c

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17324/head:pull/17324
$ git checkout pull/17324

Update a local copy of the PR:
$ git checkout pull/17324
$ git pull https://git.openjdk.org/jdk.git pull/17324/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17324

View PR using the GUI difftool:
$ git pr show -t 17324

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17324.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@JornVernee
Adding additional issue to solves list: 8322637: java/foreign/critical/TestCriticalUpcall.java timed out.

[openjdk]

@JornVernee The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (58f5cabf)
• 00: Full (2ba2851c)

[openjdk]

@JornVernee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322324: java/foreign/TestStubAllocFailure.java times out while waiting for forked process
8322637: java/foreign/critical/TestCriticalUpcall.java timed out

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• 4086176: 8322987: Remove gc/stress/gclocker/TestGCLocker* since they always fail with OOME
• 88378ed: 8277869: Maven POMs are using HTTP links where HTTPS is available
• 8569227: 8322589: Add Ideal transformation: (~a) & (~b) => ~(a | b)
• f4ca41a: 8322816: RISC-V: Incorrect guarantee in patch_vtype
• 376051a: 8320919: Clarify Locale related system properties
• a5071e0: 8322817: RISC-V: Eliminate -Wparentheses warnings in riscv code
• 28d8149: 8323115: x86-32: Incorrect predicates for cmov instruct transforms with UseSSE
• e9f7db3: 8322880: Eliminate -Wparentheses warnings in arm32 code
• aba1933: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA
• f3be138: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order
• ... and 7 more: https://git.openjdk.org/jdk/compare/37a61720b60a503a958b35c422ca4f2eb06d62fb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[JornVernee]

/integrate

[openjdk]

Going to push as commit d2d58dd.
Since your change was applied there have been 23 commits pushed to the master branch:

• b2a39c5: 8316241: Test jdk/jdk/jfr/jvm/TestChunkIntegrity.java failed
• 679f526: 8322278: Generational ZGC: Adjust the comment of ZHeuristics::use_per_cpu_shared_small_pages
• 2e472fe: 8322294: Cleanup NativePostCallNop
• 88dafe5: 8314629: Generational ZGC: Clearing All SoftReferences log line lacks GCId
• 8d94799: 8322828: Parallel: Rename ParallelCompactData::_region_start
• 9847086: 8323499: Remove unused methods in space.hpp
• 4086176: 8322987: Remove gc/stress/gclocker/TestGCLocker* since they always fail with OOME
• 88378ed: 8277869: Maven POMs are using HTTP links where HTTPS is available
• 8569227: 8322589: Add Ideal transformation: (~a) & (~b) => ~(a | b)
• f4ca41a: 8322816: RISC-V: Incorrect guarantee in patch_vtype
• ... and 13 more: https://git.openjdk.org/jdk/compare/37a61720b60a503a958b35c422ca4f2eb06d62fb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@JornVernee Pushed as commit d2d58dd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[JornVernee]

/backport jdk22

[openjdk]

@JornVernee the backport was successfully created on the branch backport-JornVernee-d2d58dd6 in my personal fork of openjdk/jdk22. To create a pull request with this backport targeting openjdk/jdk22:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit d2d58dd6 from the openjdk/jdk repository.

The commit being backported was authored by Jorn Vernee on 10 Jan 2024 and was reviewed by Maurizio Cimadamore.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk22:

$ git fetch https://github.com/openjdk-bots/jdk22.git backport-JornVernee-d2d58dd6:backport-JornVernee-d2d58dd6
$ git checkout backport-JornVernee-d2d58dd6
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk22.git backport-JornVernee-d2d58dd6