Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316241: Test jdk/jdk/jfr/jvm/TestChunkIntegrity.java failed #17328

Closed
wants to merge 1 commit into from

Conversation

mgronlun
Copy link

@mgronlun mgronlun commented Jan 9, 2024

Greetings,

This fix allows JFR artefact tagging to become deep instead of insufficiently shallow. It adjusts a race condition where one thread tags a class as being in use while another thread tags a class to be both method and used.

Testing: jdk_jfr, stress_testing

Thanks
Markus


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316241: Test jdk/jdk/jfr/jvm/TestChunkIntegrity.java failed (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17328/head:pull/17328
$ git checkout pull/17328

Update a local copy of the PR:
$ git checkout pull/17328
$ git pull https://git.openjdk.org/jdk.git pull/17328/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17328

View PR using the GUI difftool:
$ git pr show -t 17328

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17328.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2024

👋 Welcome back mgronlun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@mgronlun The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Jan 9, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 9, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@mgronlun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316241: Test jdk/jdk/jfr/jvm/TestChunkIntegrity.java failed

Reviewed-by: egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • bc05893: 8323318: Remove unused Space::is_free_block
  • dd8ae61: 8322237: Heap dump contains duplicate thread records for mounted virtual threads
  • ee98d26: 8323066: gc/g1/TestSkipRebuildRemsetPhase.java fails with 'Skipping Remembered Set Rebuild.' missing
  • 886386c: 8322890: Directly return in OldPLABSizeConstraintFunc

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 9, 2024
@mgronlun
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 10, 2024

Going to push as commit b2a39c5.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 679f526: 8322278: Generational ZGC: Adjust the comment of ZHeuristics::use_per_cpu_shared_small_pages
  • 2e472fe: 8322294: Cleanup NativePostCallNop
  • 88dafe5: 8314629: Generational ZGC: Clearing All SoftReferences log line lacks GCId
  • 8d94799: 8322828: Parallel: Rename ParallelCompactData::_region_start
  • 9847086: 8323499: Remove unused methods in space.hpp
  • 4086176: 8322987: Remove gc/stress/gclocker/TestGCLocker* since they always fail with OOME
  • 88378ed: 8277869: Maven POMs are using HTTP links where HTTPS is available
  • 8569227: 8322589: Add Ideal transformation: (~a) & (~b) => ~(a | b)
  • f4ca41a: 8322816: RISC-V: Incorrect guarantee in patch_vtype
  • 376051a: 8320919: Clarify Locale related system properties
  • ... and 9 more: https://git.openjdk.org/jdk/compare/438ab7c115249d7501edfbb2d3c62e96ae824181...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 10, 2024
@openjdk openjdk bot closed this Jan 10, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 10, 2024
@openjdk
Copy link

openjdk bot commented Jan 10, 2024

@mgronlun Pushed as commit b2a39c5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mgronlun
Copy link
Author

/backport jdk22

@openjdk
Copy link

openjdk bot commented Jan 10, 2024

@mgronlun the backport was successfully created on the branch backport-mgronlun-b2a39c57 in my personal fork of openjdk/jdk22. To create a pull request with this backport targeting openjdk/jdk22:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit b2a39c57 from the openjdk/jdk repository.

The commit being backported was authored by Markus Grönlund on 10 Jan 2024 and was reviewed by Erik Gahlin.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk22:

$ git fetch https://github.com/openjdk-bots/jdk22.git backport-mgronlun-b2a39c57:backport-mgronlun-b2a39c57
$ git checkout backport-mgronlun-b2a39c57
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk22.git backport-mgronlun-b2a39c57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
2 participants