Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8323331: fix typo hpage_pdm_size #17339

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jan 10, 2024

In https://bugs.openjdk.org/browse/JDK-8322098, Praveen Mohan pointed out that there is a typo in os_linux regarding the hpage related output. That should be fixed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17339/head:pull/17339
$ git checkout pull/17339

Update a local copy of the PR:
$ git checkout pull/17339
$ git pull https://git.openjdk.org/jdk.git pull/17339/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17339

View PR using the GUI difftool:
$ git pr show -t 17339

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17339.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 10, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 10, 2024
@openjdk
Copy link

openjdk bot commented Jan 10, 2024

@MBaesken The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jan 10, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 10, 2024

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, pmd seems to be the correct spelling:

% ls /sys/kernel/mm/transparent_hugepage/hpage_pmd_size
/sys/kernel/mm/transparent_hugepage/hpage_pmd_size

@shipilev
Copy link
Member

This is also trivial, IMO.

@openjdk
Copy link

openjdk bot commented Jan 10, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323331: fix typo hpage_pdm_size

Reviewed-by: shade, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 2806ade: 8321685: Missing ResourceMark in code called from JvmtiEnvBase::get_vthread_jvf
  • ec38505: 8323508: Remove TestGCLockerWithShenandoah.java line from TEST.groups
  • d2d58dd: 8322324: java/foreign/TestStubAllocFailure.java times out while waiting for forked process
  • b2a39c5: 8316241: Test jdk/jdk/jfr/jvm/TestChunkIntegrity.java failed
  • 679f526: 8322278: Generational ZGC: Adjust the comment of ZHeuristics::use_per_cpu_shared_small_pages
  • 2e472fe: 8322294: Cleanup NativePostCallNop
  • 88dafe5: 8314629: Generational ZGC: Clearing All SoftReferences log line lacks GCId
  • 8d94799: 8322828: Parallel: Rename ParallelCompactData::_region_start
  • 9847086: 8323499: Remove unused methods in space.hpp
  • 4086176: 8322987: Remove gc/stress/gclocker/TestGCLocker* since they always fail with OOME

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 10, 2024
@MBaesken
Copy link
Member Author

Hi Aleksey and Martin, thanks for the reviews !

/integrate

@openjdk
Copy link

openjdk bot commented Jan 10, 2024

Going to push as commit 1617067.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 2806ade: 8321685: Missing ResourceMark in code called from JvmtiEnvBase::get_vthread_jvf
  • ec38505: 8323508: Remove TestGCLockerWithShenandoah.java line from TEST.groups
  • d2d58dd: 8322324: java/foreign/TestStubAllocFailure.java times out while waiting for forked process
  • b2a39c5: 8316241: Test jdk/jdk/jfr/jvm/TestChunkIntegrity.java failed
  • 679f526: 8322278: Generational ZGC: Adjust the comment of ZHeuristics::use_per_cpu_shared_small_pages
  • 2e472fe: 8322294: Cleanup NativePostCallNop
  • 88dafe5: 8314629: Generational ZGC: Clearing All SoftReferences log line lacks GCId
  • 8d94799: 8322828: Parallel: Rename ParallelCompactData::_region_start
  • 9847086: 8323499: Remove unused methods in space.hpp
  • 4086176: 8322987: Remove gc/stress/gclocker/TestGCLocker* since they always fail with OOME

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 10, 2024
@openjdk openjdk bot closed this Jan 10, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 10, 2024
@openjdk
Copy link

openjdk bot commented Jan 10, 2024

@MBaesken Pushed as commit 1617067.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants