8323519: Add applications/ctw/modules to Hotspot tiered testing

[shipilev]

Noticed that applications/ctw/modules is missing from current tier{1,2,3,4} hotspot definitions, since tier4 specifically excludes all applications. That exclusion was due to potentially unprepared dependencies that are needed for testing: for example jcstress tests would fail with the default configuration. But CTW for JDK modules works well out of the box, so we can add it somewhere in high tier, for example tier3. It should be useful to catch compiler bugs early, before running hotspot:all.

These tests take quite a bit of time (~15 mins on my M1), so I opted to add them to relevant "slow" group that is run in tier3.

Additional testing:

• Checked that tier3_compiler runs CTW tests

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8323519: Add applications/ctw/modules to Hotspot tiered testing (Enhancement - P4)

Reviewers

• Xin Liu (@navyxliu - Committer) ⚠️ Review applies to b2694c10
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17348/head:pull/17348
$ git checkout pull/17348

Update a local copy of the PR:
$ git checkout pull/17348
$ git pull https://git.openjdk.org/jdk.git pull/17348/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17348

View PR using the GUI difftool:
$ git pr show -t 17348

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17348.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (630adcd4)
• 00: Full (b2694c10)

[navyxliu]

LGTM. I am not a reviewer.

[vnkozlov]

This will duplicate testing for us in Oracle.
Please, add it directly to tier3_compiler group instead.

[shipilev]

This will duplicate testing for us in Oracle. Please, add it directly to tier3_compiler group instead.

Now directly in tier3_compiler.

[vnkozlov]

Good.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323519: Add applications/ctw/modules to Hotspot tiered testing

Reviewed-by: xliu, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 88 new commits pushed to the master branch:

• e22ab10: 8322537: Parallel: Remove experimental adjustment in PSAdaptiveSizePolicy
• be900f1: 8323425: JFR: Auto-generated filename doesn't work with time-limited recording
• 68c4286: 8323008: filter out harmful -std* flags added by autoconf from CXX
• 7dc9dd6: 8234502: Merge GenCollectedHeap and SerialHeap
• ed18222: 8323190: Segfault during deoptimization of C2-compiled code
• 3e19bf8: 8323529: Relativize test image dependencies in microbenchmarks
• ba23025: 8322957: Generational ZGC: Relocation selection must join the STS
• 7c3a39f: 8323297: Fix incorrect placement of precompiled.hpp include lines
• e72723d: 8323296: java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java#id1 timed out
• 66520be: 8280056: gtest/LargePageGtests.java#use-large-pages failed "os.release_one_mapping_multi_commits_vm"
• ... and 78 more: https://git.openjdk.org/jdk/compare/387828a3f7e4ec5b26954747e756aac212d579ae...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Thanks!

/integrate

[openjdk]

Going to push as commit ba3c3bb.
Since your change was applied there have been 104 commits pushed to the master branch:

• 922f8e4: 8323693: Update some copyright announcements in the new files created in 8234502
• 1515bd7: 8322077: Add Ideal transformation: (~a) | (~b) => ~(a & b)
• bdee968: 4760025: sRGB conversions to and from CIE XYZ incorrect
• 71d9a83: 8323243: JNI invocation of an abstract instance method corrupts the stack
• d83ea92: 8301466: [AIX] Revisit CommittedVirtualMemoryTest
• 5cf7947: 8323562: SaslInputStream.read() may return wrong value
• dc7d3b1: 8321489: Update LCMS to 2.16
• 84cf4cb: 8318563: GetClassFields should not use random access to field
• 9e9c05f: 8322979: Add informative discussion to Modifier
• c54bca6: 8323617: Add missing null checks to GetMousePositionWithPopup.java test
• ... and 94 more: https://git.openjdk.org/jdk/compare/387828a3f7e4ec5b26954747e756aac212d579ae...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit ba3c3bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.