8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"

[mpdonova]

I was unable to recreate the error but it looks like the problem could happen if two instances of the test are run on the same machine. Also, if the deleteEntry() calls in the finally block throw an exception, they can hide any exceptions thrown earlier in the test.

I updated the test to use randomly generated alias names. I also updated the finally block so exceptions thrown by deleteEntry() are logged but not thrown.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" (Bug - P3)

Reviewers

• Rajan Halade (@rhalade - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17352/head:pull/17352
$ git checkout pull/17352

Update a local copy of the PR:
$ git checkout pull/17352
$ git pull https://git.openjdk.org/jdk.git pull/17352/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17352

View PR using the GUI difftool:
$ git pr show -t 17352

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17352.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mdonovan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mpdonova The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (c1709f66)
• 01: Full - Incremental (960b7921)
• 00: Full (475815f3)

[rhalade]

Limit this bound to the power of 2 value - 8192 to avoid re-calculation?

[rhalade]

This LGTM with minor comment to update bound and update copyright year.

[openjdk]

@mpdonova This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"

Reviewed-by: rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 94 new commits pushed to the master branch:

• de237fb: 8323554: The typos in Javadoc: "@return if "
• 51dbd36: 8322100: Fix GCMIncrementByte4 & GCMIncrementDirect4, and increase overlap testing
• ffa33d7: 8317771: [macos14] Expand/collapse a JTree using keyboard freezes the application in macOS 14 Sonoma
• 4e53235: 8323710: (fc) FileChannel.lock creates a FileKey with a poor hashCode after JDK-8321429 (win)
• 19287ee: 8321561: (fs) Clarify non-atomic behavior of Files.move
• 8b29e12: 8323794: Remove unused jimage compressor plugin configuration
• 7be9f1d: 8321137: Reconsider ICStub alignment
• b8dafa6: 8323612: IOVecWrapper should be changed to be TerminatingThreadLocal
• f2a4ed6: 8323779: Serial: Remove Generation::promotion_attempt_is_safe
• 22642ff: 8319382: com/sun/jdi/JdwpAllowTest.java shows failures on AIX if prefixLen of mask is larger than 32 in IPv6 case
• ... and 84 more: https://git.openjdk.org/jdk/compare/b78896b9aafcb15f453eaed6e154a5461581407b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mpdonova]

/integrate

[openjdk]

Going to push as commit b6233c3.
Since your change was applied there have been 106 commits pushed to the master branch:

• bfd2afe: 8275338: Add JFR events for notable serialization situations
• 4c1a0fc: 8323995: Suppress notes generated on incremental microbenchmark builds
• a2b117a: 8324132: G1: Remove unimplemented G1MonitoringSupport::recalculate_eden_size
• 8e53459: 8323993: Serial: Refactor gc_prologue and gc_epilogue
• aeb304b: 8324074: increase timeout for jvmci test TestResolvedJavaMethod.java
• a22ae90: 8321938: java/foreign/critical/TestCriticalUpcall.java does not need a core file
• 806ffb1: 8324082: more monitoring test timeout adjustments
• 52f787f: 8323595: is_aligned(p, alignof(OopT))) assertion fails in Jetty without compressed OOPs
• cbfddf4: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination
• 57fad67: 8323667: Library debug files contain non-reproducible full gcc include paths
• ... and 96 more: https://git.openjdk.org/jdk/compare/b78896b9aafcb15f453eaed6e154a5461581407b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mpdonova Pushed as commit b6233c3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.