8323296: java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java#id1 timed out

[AlanBateman]

This test was recently dialled down via JDK-8323002 but it still makes slow progress on some test machines, esp. macox-x64-debug builds. The issue is that the sampling of the target thread is skewed towards the unmounted case so the target thread is disabled from being scheduled and doesn't make progress. The test is re-worked to use a barrier so that the main thread and target virtual thread run in lock step. This allows the virtual thread to make progress at each iteration and also increases the chances of sampling the stack trace at around the time that the target thread transitions from being unmounted (due to the Thread.yield) and parking while pinned.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8323296: java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java#id1 timed out (Bug - P4)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17353/head:pull/17353
$ git checkout pull/17353

Update a local copy of the PR:
$ git checkout pull/17353
$ git pull https://git.openjdk.org/jdk.git pull/17353/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17353

View PR using the GUI difftool:
$ git pr show -t 17353

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17353.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@AlanBateman The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (4b174603)
• 00: Full (55978a82)

[jaikiran]

Thank you Alan, the changes look good to me.

[openjdk]

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323296: java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java#id1 timed out

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

• 8e12053: 8322799: Test JPKG003-013: ServiceTest fails because the user cannot uninstall the "servicetest" package on OEL 9.2 x64 and OEL 9.2 64-bit Arm (aarch64)
• e4389d8: 8323571: Regression in source resolution process
• 49e6121: 8310813: Simplify and modernize equals, hashCode, and compareTo for BigInteger
• 4ea7b36: 8322235: Split up and improve LocaleProvidersRun
• 93bedd7: 8323213: Fix some javadoc broken links in ObjectReference, and other misc javadoc cleanups
• b78896b: 8319571: Update jni/nullCaller/NullCallerTest.java to accept flags or mark as flagless
• e10d140: 8321712: C2: "failed: Multiple uses of register" in C2_MacroAssembler::vminmax_fp
• c2e77e2: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64
• 9fd855e: 8322971: KEM.getInstance() should check if a 3rd-party security provider is signed
• b8ae4a8: 8320890: [AIX] Find a better way to mimic dl handle equality
• ... and 33 more: https://git.openjdk.org/jdk/compare/f4ca41ad75fa78a08ff069ba0b6ac3596e35c23d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[AlanBateman]

/integrate

[openjdk]

Going to push as commit e72723d.
Since your change was applied there have been 47 commits pushed to the master branch:

• 66520be: 8280056: gtest/LargePageGtests.java#use-large-pages failed "os.release_one_mapping_multi_commits_vm"
• 82a63a0: 8258979: The image didn't show correctly with GTK LAF
• 8d9814a: 8322757: Enable -Wparentheses warnings
• 0ff2dea: 8320673: PageFormat/CustomPaper.java has no Pass/Fail buttons; multiple instructions
• 8e12053: 8322799: Test JPKG003-013: ServiceTest fails because the user cannot uninstall the "servicetest" package on OEL 9.2 x64 and OEL 9.2 64-bit Arm (aarch64)
• e4389d8: 8323571: Regression in source resolution process
• 49e6121: 8310813: Simplify and modernize equals, hashCode, and compareTo for BigInteger
• 4ea7b36: 8322235: Split up and improve LocaleProvidersRun
• 93bedd7: 8323213: Fix some javadoc broken links in ObjectReference, and other misc javadoc cleanups
• b78896b: 8319571: Update jni/nullCaller/NullCallerTest.java to accept flags or mark as flagless
• ... and 37 more: https://git.openjdk.org/jdk/compare/f4ca41ad75fa78a08ff069ba0b6ac3596e35c23d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@AlanBateman Pushed as commit e72723d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.