JDK-8323276: StressDirListings.java fails on AIX #17363
Conversation
|
👋 Welcome back varadam! A progress list of the required criteria for merging this PR into |
|
@varada1110 The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
|
@varada1110 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 50 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jaikiran, @dfuch) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
Updated the copyright year. |
|
@varada1110 |
|
/sponsor |
|
Going to push as commit e5aed6b.
Your commit was automatically rebased without conflicts. |
openjdk
bot
removed
ready
|
@jaikiran @varada1110 Pushed as commit e5aed6b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
|
BTW what would http server use Nagel algorithm by default and why is it affecting aix and this test so much. Is there maybe buffering or flushing missing? |
|
Hello Bernd,
I don't know about this specific AIX setup where this was causing an issue. However, in the past we have seen this happen in some other tests too on Linux (https://bugs.openjdk.org/browse/JDK-8294610). While investigating that other test, we had noticed that in a situation where there are a lot of HTTP request/response between the client and the server (like in this current StressDirListings test) and if the server responds to each request with relatively small content, then at the TCP layer on the client side, the ACKs aren't sent back to the server immediately. Instead, the (TCP) ACKs are delayed by the client's host to the server's host. This then causes the server's host to wait for the ACKs before pushing the next set of data packets to the client, even though the application layer HTTP server keeps writing out content. This ultimately boils down to what's explained in the description of https://bugs.openjdk.org/browse/JDK-6968351. |
|
ah maybe aix has not the nagel optimization which recognized full+partial packets (Minshall) |
The delay in response has caused an incomplete test and timeout error. Setting the TCP_NODELAY socket option to 1 by the property sun.net.httpserver.nodelay solves the issue.
JBS Issue : JDK-8323276
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17363/head:pull/17363$ git checkout pull/17363Update a local copy of the PR:
$ git checkout pull/17363$ git pull https://git.openjdk.org/jdk.git pull/17363/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 17363View PR using the GUI difftool:
$ git pr show -t 17363Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17363.diff
Webrev
Link to Webrev Comment