-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8301994: Remove unused code from awt_List.cpp #17378
Conversation
👋 Welcome back rmahajan! A progress list of the required criteria for merging this PR into |
Webrevs
|
@rajamah This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 39 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb, @prrace, @aivanov-jdk) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
removed extra blank line at the end of the function.
/integrate |
/sponsor |
Going to push as commit 8b6293f.
Your commit was automatically rebased without conflicts. |
@aivanov-jdk @rajamah Pushed as commit 8b6293f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Remove commented out/ unused code from awt_List.cpp, which has been commented out since 2007, when the code was moved to Mercurial.
The test ScrollPaneLimitation.java has been opened under JDK-8306137, and it should be safe to remove this code now.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17378/head:pull/17378
$ git checkout pull/17378
Update a local copy of the PR:
$ git checkout pull/17378
$ git pull https://git.openjdk.org/jdk.git pull/17378/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 17378
View PR using the GUI difftool:
$ git pr show -t 17378
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17378.diff
Webrev
Link to Webrev Comment