Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301994: Remove unused code from awt_List.cpp #17378

Closed
wants to merge 2 commits into from

Conversation

rajamah
Copy link
Member

@rajamah rajamah commented Jan 11, 2024

Remove commented out/ unused code from awt_List.cpp, which has been commented out since 2007, when the code was moved to Mercurial.
The test ScrollPaneLimitation.java has been opened under JDK-8306137, and it should be safe to remove this code now.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8301994: Remove unused code from awt_List.cpp (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17378/head:pull/17378
$ git checkout pull/17378

Update a local copy of the PR:
$ git checkout pull/17378
$ git pull https://git.openjdk.org/jdk.git pull/17378/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17378

View PR using the GUI difftool:
$ git pr show -t 17378

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17378.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 11, 2024

👋 Welcome back rmahajan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 11, 2024
@openjdk
Copy link

openjdk bot commented Jan 11, 2024

@rajamah The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jan 11, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 11, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 11, 2024

@rajamah This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301994: Remove unused code from awt_List.cpp

Reviewed-by: serb, prr, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

  • e33031b: 8323629: Shenandoah: Fix missing include and declaration
  • c5e7245: 8322735: C2: minor improvements of bubble sort used in SuperWord::packset_sort
  • 65a0672: 8319773: Avoid inflating monitors when installing hash codes for LM_LIGHTWEIGHT
  • e22ab10: 8322537: Parallel: Remove experimental adjustment in PSAdaptiveSizePolicy
  • be900f1: 8323425: JFR: Auto-generated filename doesn't work with time-limited recording
  • 68c4286: 8323008: filter out harmful -std* flags added by autoconf from CXX
  • 7dc9dd6: 8234502: Merge GenCollectedHeap and SerialHeap
  • ed18222: 8323190: Segfault during deoptimization of C2-compiled code
  • 3e19bf8: 8323529: Relativize test image dependencies in microbenchmarks
  • ba23025: 8322957: Generational ZGC: Relocation selection must join the STS
  • ... and 29 more: https://git.openjdk.org/jdk/compare/5ba69e17340cf44194c080a38219c6e150418fcf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb, @prrace, @aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 11, 2024
@rajamah
Copy link
Member Author

rajamah commented Jan 12, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 12, 2024
@openjdk
Copy link

openjdk bot commented Jan 12, 2024

@rajamah
Your change (at version 6d1045d) is now ready to be sponsored by a Committer.

removed extra blank line at the end of the function.
@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Jan 12, 2024
@rajamah
Copy link
Member Author

rajamah commented Jan 12, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 12, 2024
@openjdk
Copy link

openjdk bot commented Jan 12, 2024

@rajamah
Your change (at version fe1ec21) is now ready to be sponsored by a Committer.

@aivanov-jdk
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 12, 2024

Going to push as commit 8b6293f.
Since your change was applied there have been 39 commits pushed to the master branch:

  • e33031b: 8323629: Shenandoah: Fix missing include and declaration
  • c5e7245: 8322735: C2: minor improvements of bubble sort used in SuperWord::packset_sort
  • 65a0672: 8319773: Avoid inflating monitors when installing hash codes for LM_LIGHTWEIGHT
  • e22ab10: 8322537: Parallel: Remove experimental adjustment in PSAdaptiveSizePolicy
  • be900f1: 8323425: JFR: Auto-generated filename doesn't work with time-limited recording
  • 68c4286: 8323008: filter out harmful -std* flags added by autoconf from CXX
  • 7dc9dd6: 8234502: Merge GenCollectedHeap and SerialHeap
  • ed18222: 8323190: Segfault during deoptimization of C2-compiled code
  • 3e19bf8: 8323529: Relativize test image dependencies in microbenchmarks
  • ba23025: 8322957: Generational ZGC: Relocation selection must join the STS
  • ... and 29 more: https://git.openjdk.org/jdk/compare/5ba69e17340cf44194c080a38219c6e150418fcf...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 12, 2024
@openjdk openjdk bot closed this Jan 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 12, 2024
@openjdk
Copy link

openjdk bot commented Jan 12, 2024

@aivanov-jdk @rajamah Pushed as commit 8b6293f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants