4760025: sRGB conversions to and from CIE XYZ incorrect

[mrserb]

Since the time the bug was reported color conversion accuracy for the sRGB profile and specific values from the report increased by x100. This is a request to add the code from the report as a test case.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-4760025: sRGB conversions to and from CIE XYZ incorrect (Bug - P4)

Reviewers

• Phil Race (@prrace - Reviewer) ⚠️ Review applies to 8925fbd5
• Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17388/head:pull/17388
$ git checkout pull/17388

Update a local copy of the PR:
$ git checkout pull/17388
$ git pull https://git.openjdk.org/jdk.git pull/17388/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17388

View PR using the GUI difftool:
$ git pr show -t 17388

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17388.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (8e48839f)
• 02: Full - Incremental (726f461e)
• 01: Full - Incremental (8925fbd5)
• 00: Full (e099466a)

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

4760025: sRGB conversions to and from CIE XYZ incorrect

Reviewed-by: prr, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• d83ea92: 8301466: [AIX] Revisit CommittedVirtualMemoryTest
• 5cf7947: 8323562: SaslInputStream.read() may return wrong value
• dc7d3b1: 8321489: Update LCMS to 2.16
• 84cf4cb: 8318563: GetClassFields should not use random access to field
• 9e9c05f: 8322979: Add informative discussion to Modifier
• c54bca6: 8323617: Add missing null checks to GetMousePositionWithPopup.java test
• 95a9168: 8323627: Shenandoah: Refactor init logger
• 999e556: 8312518: [macos13] setFullScreenWindow() shows black screen on macOS 13 & above
• 8b6293f: 8301994: Remove unused code from awt_List.cpp
• e33031b: 8323629: Shenandoah: Fix missing include and declaration
• ... and 15 more: https://git.openjdk.org/jdk/compare/8e12053e0352a26ecd7f2b9bc298ddb8fb4bb61b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[aivanov-jdk]

Arrays.toString(rgb) instead of custom toString?

[mrserb]

+1

[mrserb]

/integrate

[openjdk]

Going to push as commit bdee968.
Since your change was applied there have been 26 commits pushed to the master branch:

• 71d9a83: 8323243: JNI invocation of an abstract instance method corrupts the stack
• d83ea92: 8301466: [AIX] Revisit CommittedVirtualMemoryTest
• 5cf7947: 8323562: SaslInputStream.read() may return wrong value
• dc7d3b1: 8321489: Update LCMS to 2.16
• 84cf4cb: 8318563: GetClassFields should not use random access to field
• 9e9c05f: 8322979: Add informative discussion to Modifier
• c54bca6: 8323617: Add missing null checks to GetMousePositionWithPopup.java test
• 95a9168: 8323627: Shenandoah: Refactor init logger
• 999e556: 8312518: [macos13] setFullScreenWindow() shows black screen on macOS 13 & above
• 8b6293f: 8301994: Remove unused code from awt_List.cpp
• ... and 16 more: https://git.openjdk.org/jdk/compare/8e12053e0352a26ecd7f2b9bc298ddb8fb4bb61b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb Pushed as commit bdee968.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.