Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258056: jdk/javadoc/doclet/testHtmlTableTags/TestHtmlTableTags.java fails against jdk17 #1739

Closed
wants to merge 1 commit into from

Conversation

iignatev
Copy link
Member

@iignatev iignatev commented Dec 10, 2020

Hi all,

could you pleaes review this small and trivial fix for jdk/javadoc/doclet/testHtmlTableTags/TestHtmlTableTags.java test? the test faled to find "https://download.java.net/java/early_access/jdk16/" string after we switched to jdk17, the patch is basically s/jdk16/jdk17/g.

testing: test/langtools/jdk/javadoc/doclet/testHtmlTableTags/TestHtmlTableTags.java

Thanks,
-- Igor


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258056: jdk/javadoc/doclet/testHtmlTableTags/TestHtmlTableTags.java fails against jdk17

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1739/head:pull/1739
$ git checkout pull/1739

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 10, 2020

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 10, 2020
@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@iignatev The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc javadoc-dev@openjdk.org label Dec 10, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 10, 2020

Webrevs

Copy link
Member

@JesperIRL JesperIRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258056: jdk/javadoc/doclet/testHtmlTableTags/TestHtmlTableTags.java fails against jdk17

Reviewed-by: jwilhelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 42264b2: 8257971: (fs) Remove unused code from WindowsPath.subpath(begin, end)
  • 3342eca: 8258054: runtime/sealedClasses/GetPermittedSubclassesTest.java fails w/ jdk17

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 10, 2020
@iignatev
Copy link
Member Author

Thanks Jesper.

/integrate

@openjdk openjdk bot closed this Dec 10, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 10, 2020
@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@iignatev Since your change was applied there have been 2 commits pushed to the master branch:

  • 42264b2: 8257971: (fs) Remove unused code from WindowsPath.subpath(begin, end)
  • 3342eca: 8258054: runtime/sealedClasses/GetPermittedSubclassesTest.java fails w/ jdk17

Your commit was automatically rebased without conflicts.

Pushed as commit 164c55b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@navyxliu
Copy link
Member

This commit seems not to pass your workflow.
https://github.com/iignatev/jdk/actions/runs/413640509

@iignatev
Copy link
Member Author

This commit seems not to pass your workflow.
https://github.com/iignatev/jdk/actions/runs/413640509

thanks for letting me know, the failures you linked to are b/c of 8258054 which got fixed by #1738

@iignatev iignatev deleted the 8258056 branch December 10, 2020 23:44
@hns
Copy link
Member

hns commented Dec 11, 2020

Thanks for quickly fixing this, @iignatev!

This was a stupid mistake of mine to add a test that contains a pre-release platform documentation URL. I'll take care of fixing the root cause, which is not to generate platform documentation links in the first place. JBS issue filed here: https://bugs.openjdk.java.net/browse/JDK-8258092

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org
4 participants