8323637: Capture hotspot replay files in GHA

[magicus]

From the bug report:

jdk/.github/scripts/gen-test-results.sh is capable of capture hs_err_* file for erroneous and failed tests. They are also exposed under tag <details><summary>View HotSpot error log</summary>.

I think we can do the same thing for replay files. A replay file is automatically generated when compiler threads encounter a fatal error. sometimes, we can only trigger the compilation error on GHA. attached replay file is invaluable.

---

I have not figured out how to provoke a replay file on GHA, so this is untested, but since it is based on the hs_err logic I'm pretty confident that it works. If it turns out to be problematic, let's fix it in a follow up.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8323637: Capture hotspot replay files in GHA (Enhancement - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17392/head:pull/17392
$ git checkout pull/17392

Update a local copy of the PR:
$ git checkout pull/17392
$ git pull https://git.openjdk.org/jdk.git pull/17392/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17392

View PR using the GUI difftool:
$ git pr show -t 17392

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17392.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@magicus The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (6f242e56)
• 02: Full - Incremental (a19a333d)
• 01: Full - Incremental (375a2fd1)
• 00: Full (ff8e1589)

[shipilev]

Looks good.

Except that current GHA is broken, and we would want to give it as spin before integrating. I sent a note to ops@ about this yesterday, but got no reply. Maybe you can poke them a bit? The problem is the git.openjdk.java.net forwarder not working...

[openjdk]

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323637: Capture hotspot replay files in GHA

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

• 8c238ed: 8318707: Remove the Java Management Extension (JMX) Management Applet (m-let) feature
• cd0fe37: 8323641: Test compiler/loopopts/superword/TestAlignVectorFuzzer.java timed out
• 45c65e6: 8323577: C2 SuperWord: remove AlignVector restrictions on IR tests added in JDK-8305055
• 8643cc2: 8323610: G1: HeapRegion pin count should be size_t to avoid overflows
• e66a76f: 8323660: Serial: Fix header ordering and indentation
• ba3c3bb: 8323519: Add applications/ctw/modules to Hotspot tiered testing
• 922f8e4: 8323693: Update some copyright announcements in the new files created in 8234502
• 1515bd7: 8322077: Add Ideal transformation: (~a) | (~b) => ~(a & b)
• bdee968: 4760025: sRGB conversions to and from CIE XYZ incorrect
• 71d9a83: 8323243: JNI invocation of an abstract instance method corrupts the stack
• ... and 17 more: https://git.openjdk.org/jdk/compare/3e19bf88d5b51fe10c183f930b99bce961a368c1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[magicus]

I agree, we want to see green checks for GHA. I thought it looked like my GHA runs on another branch was working, so maybe it is fixed now. Trying to get GHA to rerun by pushing an empty commit; I have forgotten if this in fact works. :)

[magicus]

(Sorry for the force push, I added a dummy commit locally touching real files, but I never intended to push it to this branch)

[openjdk]

@magicus Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[shipilev]

BTW, you can just go to https://github.com/magicus/jdk/actions/workflows/main.yml -- and trigger the workflow on your branch by hand, without doing any commits. Bots would pick that up.

[magicus]

I did not think such a run would show up in the check status in the PR..? But maybe the bots are more intelligent than I give them credit for. 🤖 I'll try that next time, thanks!

[shipilev]

I did not think such a run would show up in the check status in the PR..? But maybe the bots are more intelligent than I give them credit for. 🤖 I'll try that next time, thanks!

They would show up here, just not instantaneously. I do that for both initial and workflow re-runs all the time.

[magicus]

/integrate

[openjdk]

Going to push as commit c84c0ab.
Since your change was applied there have been 32 commits pushed to the master branch:

• f368a0c: 8320328: Restore interrupted flag in ImageIcon.loadImage
• a45b5b4: 8323722: Serial: Remove unused no_gc_in_progress
• 7e0a4ed: 8323101: C2: assert(n->in(0) == nullptr) failed: divisions with zero check should already have bailed out earlier in split-if
• 34f85ee: 8323584: AArch64: Unnecessary ResourceMark in NativeCall::set_destination_mt_safe
• 62fd26f: 8323700: Add fontconfig requirement to building.md for Alpine Linux
• 8c238ed: 8318707: Remove the Java Management Extension (JMX) Management Applet (m-let) feature
• cd0fe37: 8323641: Test compiler/loopopts/superword/TestAlignVectorFuzzer.java timed out
• 45c65e6: 8323577: C2 SuperWord: remove AlignVector restrictions on IR tests added in JDK-8305055
• 8643cc2: 8323610: G1: HeapRegion pin count should be size_t to avoid overflows
• e66a76f: 8323660: Serial: Fix header ordering and indentation
• ... and 22 more: https://git.openjdk.org/jdk/compare/3e19bf88d5b51fe10c183f930b99bce961a368c1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@magicus Pushed as commit c84c0ab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.