Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8250859: Address reliance on default constructors in the Accessibility APIs #174

Closed
wants to merge 4 commits into from

Conversation

@c-cleary
Copy link
Contributor

@c-cleary c-cleary commented Sep 15, 2020

This issue relates to JDK-8250639 ' Address reliance on default constructors in the java.desktop module'. The following classes have had an explicit no-arg constructor added, with a protected access modifier and accompanying API description:

  • Default ctor on com.sun.java.accessibility.util.SwingEventMonitor
  • Default ctor on javax.accessibility.AccessibleContext
  • Default ctor on javax.accessibility.AccessibleHyperlink

The following classes have had an explicit no-arg constructor added, with a public access modifier and accompanying API description:

  • Default ctor on javax.accessibility.AccessibleResourceBundle
  • Default ctor on com.sun.java.accessibility.util.AWTEventMonitor
  • Default ctor on com.sun.java.accessibility.util.AccessibilityEventMonitor
  • Default ctor on com.sun.java.accessibility.util.AccessibilityListenerList
  • Default ctor on com.sun.java.accessibility.util.EventID

specdiff: http://cr.openjdk.java.net/~ccleary/issues/webrevs-store/8250859/webrevs/webrev.00/specdiff/overview-summary.html
bug: https://bugs.openjdk.java.net/browse/JDK-8250859


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8250859: Address reliance on default constructors in the Accessibility APIs

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/174/head:pull/174
$ git checkout pull/174

@c-cleary
Copy link
Contributor Author

@c-cleary c-cleary commented Sep 15, 2020

/csr

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 15, 2020

👋 Welcome back ccleary! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@ccleary-oracle only Reviewers are allowed require a CSR.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@ccleary-oracle The following labels will be automatically applied to this pull request: 2d core-libs.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label (add|remove) "label" command.

@c-cleary c-cleary marked this pull request as ready for review Sep 15, 2020
@openjdk openjdk bot added the rfr label Sep 15, 2020
@c-cleary
Copy link
Contributor Author

@c-cleary c-cleary commented Sep 15, 2020

Changes require approval of CSR, can't request that requirement myself as I am not a reviewer

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 15, 2020

Webrevs

@dfuch
Copy link
Member

@dfuch dfuch commented Sep 15, 2020

/csr

@openjdk openjdk bot added the csr label Sep 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@dfuch this pull request will not be integrated until the CSR request JDK-8253054 for issue JDK-8250859 has been approved.

prrace
prrace approved these changes Sep 15, 2020
Copy link
Contributor

@prrace prrace left a comment

This looks OK but the CSR needs updates first.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@ccleary-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8250859: Address reliance on default constructors in the Accessibility APIs

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 124 new commits pushed to the master branch:

  • 89c5e49: 8253500: [REDO] JDK-8253208 Move CDS related code to a separate class
  • bf442c5: 8253539: Remove unused JavaThread functions for set_last_Java_fp/pc
  • dd2c456: 8253583: java/util/StringJoiner tests failing on 32-bit VMs after JDK-8246697
  • b1e2f02: 8253524: C2: Refactor code that clones predicates during loop unswitching
  • c303fd5: 8253581: runtime/stringtable/StringTableCleaningTest.java fails on 32-bit platforms
  • f3ea0d3: 8252583: Clean up unused phi-to-copy degradation mechanism
  • 4440bda: 8219586: CodeHeap State Analytics processes dead nmethods
  • 154b8cf: 8253014: OopStorage bulk release logs entries multiple times
  • ba174af: 8253048: AArch64: When CallLeaf, no need to preserve callee-saved registers in caller
  • 3320fc0: 8253372: [TESTBUG] update tests which require jvmti - hotspot
  • ... and 114 more: https://git.openjdk.java.net/jdk/compare/74851c507bed9eb2e1e0b0eac3b53a74decb2588...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Sep 15, 2020
@ChrisHegarty
Copy link
Member

@ChrisHegarty ChrisHegarty commented Sep 16, 2020

The CSR lists com.sun.java.accessibility.util.SwingEventMonitor as being changed, but I cannot find that class in this PR.

@c-cleary
Copy link
Contributor Author

@c-cleary c-cleary commented Sep 17, 2020

The CSR lists com.sun.java.accessibility.util.SwingEventMonitor as being changed, but I cannot find that class in this PR.

Changes to this class were indeed missing. This has now been addressed. Thanks for spotting that!

@openjdk openjdk bot removed the csr label Sep 21, 2020
@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Sep 23, 2020

/label remove core-libs

@openjdk openjdk bot removed the core-libs label Sep 23, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2020

@AlanBateman
The core-libs label was successfully removed.

@c-cleary
Copy link
Contributor Author

@c-cleary c-cleary commented Sep 23, 2020

/integrate

@openjdk openjdk bot added the sponsor label Sep 23, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2020

@ccleary-oracle
Your change (at version bc02a4d) is now ready to be sponsored by a Committer.

@prrace
Copy link
Contributor

@prrace prrace commented Sep 24, 2020

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2020

@prrace @ccleary-oracle Since your change was applied there have been 124 commits pushed to the master branch:

  • 89c5e49: 8253500: [REDO] JDK-8253208 Move CDS related code to a separate class
  • bf442c5: 8253539: Remove unused JavaThread functions for set_last_Java_fp/pc
  • dd2c456: 8253583: java/util/StringJoiner tests failing on 32-bit VMs after JDK-8246697
  • b1e2f02: 8253524: C2: Refactor code that clones predicates during loop unswitching
  • c303fd5: 8253581: runtime/stringtable/StringTableCleaningTest.java fails on 32-bit platforms
  • f3ea0d3: 8252583: Clean up unused phi-to-copy degradation mechanism
  • 4440bda: 8219586: CodeHeap State Analytics processes dead nmethods
  • 154b8cf: 8253014: OopStorage bulk release logs entries multiple times
  • ba174af: 8253048: AArch64: When CallLeaf, no need to preserve callee-saved registers in caller
  • 3320fc0: 8253372: [TESTBUG] update tests which require jvmti - hotspot
  • ... and 114 more: https://git.openjdk.java.net/jdk/compare/74851c507bed9eb2e1e0b0eac3b53a74decb2588...master

Your commit was automatically rebased without conflicts.

Pushed as commit a9d0440.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants