Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258059: Clean up MethodData::profile_unsafe #1740

Closed
wants to merge 1 commit into from

Conversation

cl4es
Copy link
Member

@cl4es cl4es commented Dec 10, 2020

Following up on comments to #1733

  • Simplify by using Symbol::starts_with
  • Bytecode_invoke methods are not inlineable, so locals avoid redundant calls

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1740/head:pull/1740
$ git checkout pull/1740

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 10, 2020

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2020

@cl4es The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Dec 10, 2020
@cl4es
Copy link
Member Author

@cl4es cl4es commented Dec 10, 2020

/label remove hotspot
/label add hotspot-compiler
/label add hotspot-runtime

@openjdk openjdk bot removed the hotspot label Dec 10, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2020

@cl4es
The hotspot label was successfully removed.

@openjdk openjdk bot added the hotspot-compiler label Dec 10, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2020

@cl4es
The hotspot-compiler label was successfully added.

@openjdk openjdk bot added the hotspot-runtime label Dec 10, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2020

@cl4es
The hotspot-runtime label was successfully added.

@cl4es cl4es marked this pull request as ready for review Dec 10, 2020
@openjdk openjdk bot added the rfr label Dec 10, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 10, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Dec 11, 2020

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258059: Clean up MethodData::profile_unsafe

Reviewed-by: roland, chegar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • b28b094: 8257145: Performance regression with -XX:-ResizePLAB after JDK-8079555
  • fa20186: 8257676: Simplify WeakProcessorPhase
  • b90b7f5: 8196090: javax/swing/JComboBox/6559152/bug6559152.java fails
  • 1d15ebe: 8243205: Modularize JVM flags declaration
  • 8befc32: 8258073: x86_32 build broken after JDK-8257731
  • 37dc675: 8247402: Documentation for Map::compute contains confusing implementation requirements
  • d4282b0: 8257731: Remove excessive include of stubRoutines.hpp
  • 80dac5a: 8257912: Convert enum iteration to use range-based for loops
  • 164c55b: 8258056: jdk/javadoc/doclet/testHtmlTableTags/TestHtmlTableTags.java fails against jdk17
  • 42264b2: 8257971: (fs) Remove unused code from WindowsPath.subpath(begin, end)
  • ... and 1 more: https://git.openjdk.java.net/jdk/compare/f57405617ead0139b31fb19f961c46aa45bc844b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 11, 2020
@cl4es
Copy link
Member Author

@cl4es cl4es commented Dec 11, 2020

@rwestrel @ChrisHegarty - thank you for reviewing!

@cl4es
Copy link
Member Author

@cl4es cl4es commented Dec 11, 2020

/integrate

@openjdk openjdk bot closed this Dec 11, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 11, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 11, 2020

@cl4es Since your change was applied there have been 12 commits pushed to the master branch:

  • b5592c0: 8257970: Remove julong types in os::limit_heap_by_allocatable_memory
  • b28b094: 8257145: Performance regression with -XX:-ResizePLAB after JDK-8079555
  • fa20186: 8257676: Simplify WeakProcessorPhase
  • b90b7f5: 8196090: javax/swing/JComboBox/6559152/bug6559152.java fails
  • 1d15ebe: 8243205: Modularize JVM flags declaration
  • 8befc32: 8258073: x86_32 build broken after JDK-8257731
  • 37dc675: 8247402: Documentation for Map::compute contains confusing implementation requirements
  • d4282b0: 8257731: Remove excessive include of stubRoutines.hpp
  • 80dac5a: 8257912: Convert enum iteration to use range-based for loops
  • 164c55b: 8258056: jdk/javadoc/doclet/testHtmlTableTags/TestHtmlTableTags.java fails against jdk17
  • ... and 2 more: https://git.openjdk.java.net/jdk/compare/f57405617ead0139b31fb19f961c46aa45bc844b...master

Your commit was automatically rebased without conflicts.

Pushed as commit ff75ad5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-runtime integrated
3 participants