-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8323695 RenderPerf (2D) enhancements (23.12) #17408
Conversation
- new executor modes (buffer & volatile) - support parallel rendering on several frames and / or screens - added robot calibration + optionally use rounded duration to min frame latency (120Hz) - give more statistics in verbose (-v) - added new command-line arguments - added version + help information
👋 Welcome back lbourges! A progress list of the required criteria for merging this PR into |
Webrevs
|
test/jdk/performance/client/RenderPerfTest/src/renderperf/RenderPerfTest.java
Outdated
Show resolved
Hide resolved
I updated my RenderPerf git with release 23.12: Works on jdk8+ |
test/jdk/performance/client/RenderPerfTest/src/renderperf/RenderPerfTest.java
Show resolved
Hide resolved
test/jdk/performance/client/RenderPerfTest/src/renderperf/RenderPerfTest.java
Outdated
Show resolved
Hide resolved
- improved stddev estimation based on InterQuantileRange (IQR for fps) or MeanAbsoluteDeviation (MAD for time) - new font arguments (font name, size, text) - added result table header - improved result output (text)
test/jdk/performance/client/RenderPerfTest/src/renderperf/RenderPerfTest.java
Outdated
Show resolved
Hide resolved
test/jdk/performance/client/RenderPerfTest/src/renderperf/RenderPerfTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@bourgesl This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 490 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 8b30503.
Your commit was automatically rebased without conflicts. |
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17408/head:pull/17408
$ git checkout pull/17408
Update a local copy of the PR:
$ git checkout pull/17408
$ git pull https://git.openjdk.org/jdk.git pull/17408/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 17408
View PR using the GUI difftool:
$ git pr show -t 17408
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17408.diff
Webrev
Link to Webrev Comment