Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8323695 RenderPerf (2D) enhancements (23.12) #17408

Closed
wants to merge 5 commits into from

Conversation

bourgesl
Copy link
Contributor

@bourgesl bourgesl commented Jan 12, 2024

  • new executor modes (buffer & volatile)
  • support parallel rendering on several frames and / or screens
  • added robot calibration + optionally use rounded duration to min frame latency (120Hz)
  • give more statistics in verbose (-v)
  • added new command-line arguments
  • added version + help information

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8323695: RenderPerf (2D) enhancements (23.12) (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17408/head:pull/17408
$ git checkout pull/17408

Update a local copy of the PR:
$ git checkout pull/17408
$ git pull https://git.openjdk.org/jdk.git pull/17408/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17408

View PR using the GUI difftool:
$ git pr show -t 17408

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17408.diff

Webrev

Link to Webrev Comment

- new executor modes (buffer & volatile)
- support parallel rendering on several frames and / or screens
- added robot calibration + optionally use rounded duration to min frame latency (120Hz)
- give more statistics in verbose (-v)
- added new command-line arguments
- added version + help information
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 12, 2024

👋 Welcome back lbourges! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 12, 2024

@bourgesl The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jan 12, 2024
@bourgesl bourgesl changed the title RenderPerf 23.12 enhancements: JDK-8323695: RenderPerf 23.12 enhancements: Jan 13, 2024
@bourgesl bourgesl changed the title JDK-8323695: RenderPerf 23.12 enhancements: JDK-8323695 RenderPerf (2D) enhancements (23.12) Jan 13, 2024
@bourgesl bourgesl marked this pull request as ready for review January 13, 2024 14:40
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 13, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 13, 2024

Webrevs

@bourgesl
Copy link
Contributor Author

@prrace here it the renderperf patch.
@mrserb

@bourgesl
Copy link
Contributor Author

I updated my RenderPerf git with release 23.12:
https://github.com/bourgesl/RenderPerf
https://github.com/bourgesl/RenderPerf/releases/tag/v23_12

Works on jdk8+

- improved stddev estimation based on InterQuantileRange (IQR for fps) or MeanAbsoluteDeviation (MAD for time)
- new font arguments (font name, size, text)
- added result table header
- improved result output (text)
Copy link
Contributor

@avu avu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@openjdk
Copy link

openjdk bot commented Feb 21, 2024

@bourgesl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323695: RenderPerf (2D) enhancements (23.12)

Reviewed-by: avu, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 490 new commits pushed to the master branch:

  • 64f7972: 8326158: Javadoc for java.time.DayOfWeek#minus(long)
  • f0f4d63: 8326351: Update the Zlib version in open/src/java.base/share/legal/zlib.md to 1.3.1
  • 51e2dde: 8326235: RISC-V: Size CodeCache for short calls encoding
  • c022431: 8326412: debuginfo files should not have executable bit set
  • 33834b7: 8326375: [REDO] Clean up NativeCompilation.gmk and its newly created parts
  • 2352268: 8326334: JFR failed assert(used(klass)) failed: invariant
  • 492e8bf: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM
  • 5f16f34: 8326370: Remove redundant and misplaced micros from StringBuffers
  • 921507c: 8326319: G1: Remove unused G1ConcurrentMark::_init_times
  • 68eb5a1: 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support
  • ... and 480 more: https://git.openjdk.org/jdk/compare/65a0672791f868556776fc435b37319ed69f7c84...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 21, 2024
@bourgesl
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 22, 2024

Going to push as commit 8b30503.
Since your change was applied there have been 492 commits pushed to the master branch:

  • 8e5f6dd: 8324243: Compilation failures in java.desktop module with gcc 14
  • 0bcece9: 8325342: Remove unneeded exceptions in compare.sh
  • 64f7972: 8326158: Javadoc for java.time.DayOfWeek#minus(long)
  • f0f4d63: 8326351: Update the Zlib version in open/src/java.base/share/legal/zlib.md to 1.3.1
  • 51e2dde: 8326235: RISC-V: Size CodeCache for short calls encoding
  • c022431: 8326412: debuginfo files should not have executable bit set
  • 33834b7: 8326375: [REDO] Clean up NativeCompilation.gmk and its newly created parts
  • 2352268: 8326334: JFR failed assert(used(klass)) failed: invariant
  • 492e8bf: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM
  • 5f16f34: 8326370: Remove redundant and misplaced micros from StringBuffers
  • ... and 482 more: https://git.openjdk.org/jdk/compare/65a0672791f868556776fc435b37319ed69f7c84...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 22, 2024
@openjdk openjdk bot closed this Feb 22, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 22, 2024
@openjdk
Copy link

openjdk bot commented Feb 22, 2024

@bourgesl Pushed as commit 8b30503.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants