Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8323700: Add fontconfig requirement to building.md for Alpine Linux #17415

Closed

Conversation

jankratochvil
Copy link
Contributor

@jankratochvil jankratochvil commented Jan 14, 2024

Similar to JDK-8309287.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8323700: Add fontconfig requirement to building.md for Alpine Linux (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17415/head:pull/17415
$ git checkout pull/17415

Update a local copy of the PR:
$ git checkout pull/17415
$ git pull https://git.openjdk.org/jdk.git pull/17415/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17415

View PR using the GUI difftool:
$ git pr show -t 17415

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17415.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 14, 2024

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 14, 2024
@openjdk
Copy link

openjdk bot commented Jan 14, 2024

@jankratochvil The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Jan 14, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 14, 2024

Webrevs

@TheShermanTanker
Copy link
Contributor

If building.md is modified, building.html also has to be refreshed by running make update-build-docs

@jankratochvil
Copy link
Contributor Author

make update-build-docs

Done, sorry.

@openjdk
Copy link

openjdk bot commented Jan 15, 2024

@jankratochvil This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323700: Add fontconfig requirement to building.md for Alpine Linux

Reviewed-by: ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • cd0fe37: 8323641: Test compiler/loopopts/superword/TestAlignVectorFuzzer.java timed out
  • 45c65e6: 8323577: C2 SuperWord: remove AlignVector restrictions on IR tests added in JDK-8305055
  • 8643cc2: 8323610: G1: HeapRegion pin count should be size_t to avoid overflows
  • e66a76f: 8323660: Serial: Fix header ordering and indentation
  • ba3c3bb: 8323519: Add applications/ctw/modules to Hotspot tiered testing
  • 922f8e4: 8323693: Update some copyright announcements in the new files created in 8234502
  • 1515bd7: 8322077: Add Ideal transformation: (~a) | (~b) => ~(a & b)
  • bdee968: 4760025: sRGB conversions to and from CIE XYZ incorrect
  • 71d9a83: 8323243: JNI invocation of an abstract instance method corrupts the stack

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@magicus) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 15, 2024
@jankratochvil
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 15, 2024
@openjdk
Copy link

openjdk bot commented Jan 15, 2024

@jankratochvil
Your change (at version 913b91d) is now ready to be sponsored by a Committer.

@magicus
Copy link
Member

magicus commented Jan 15, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 15, 2024

Going to push as commit 62fd26f.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 8c238ed: 8318707: Remove the Java Management Extension (JMX) Management Applet (m-let) feature
  • cd0fe37: 8323641: Test compiler/loopopts/superword/TestAlignVectorFuzzer.java timed out
  • 45c65e6: 8323577: C2 SuperWord: remove AlignVector restrictions on IR tests added in JDK-8305055
  • 8643cc2: 8323610: G1: HeapRegion pin count should be size_t to avoid overflows
  • e66a76f: 8323660: Serial: Fix header ordering and indentation
  • ba3c3bb: 8323519: Add applications/ctw/modules to Hotspot tiered testing
  • 922f8e4: 8323693: Update some copyright announcements in the new files created in 8234502
  • 1515bd7: 8322077: Add Ideal transformation: (~a) | (~b) => ~(a & b)
  • bdee968: 4760025: sRGB conversions to and from CIE XYZ incorrect
  • 71d9a83: 8323243: JNI invocation of an abstract instance method corrupts the stack

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 15, 2024
@openjdk openjdk bot closed this Jan 15, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 15, 2024
@openjdk
Copy link

openjdk bot commented Jan 15, 2024

@magicus @jankratochvil Pushed as commit 62fd26f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants