8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3

[tschatzl]

Hi all,

please review this fix to the TestHumongousConcurrentStart test that changes execution so that additional test options are not passed on to the test as it is sensitive to the type of gcs that occur. An alternative would be just excluding -Xcomp to fix this particular occurrence, but I wanted to avoid having to revisit this issue again.

Testing: that test on aarch64 does not fail any more

Hth,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3 (Bug - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17419/head:pull/17419
$ git checkout pull/17419

Update a local copy of the PR:
$ git checkout pull/17419
$ git pull https://git.openjdk.org/jdk.git pull/17419/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17419

View PR using the GUI difftool:
$ git pr show -t 17419

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17419.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0626e34d)

[shipilev]

Looks fine

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3

Reviewed-by: shade, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• b363472: 8318227: RISC-V: C2 ConvHF2F
• edc0ebb: 8323745: Missing comma in copyright header in TestScope
• a03eb6d: 8321620: Optimize JImage decompressors
• f5b757c: 8323159: Consider adding some text re. memory zeroing in Arena::allocate
• 1f4474f: 8323726: Serial: Remove unused definitions in Generation
• dd0694b: 8323671: DevKit build gcc libraries contain full paths to source location
• bf813be: 8322279: Generational ZGC: Use ZFragmentationLimit and ZYoungCompactionLimit as percentage instead of multiples
• c84c0ab: 8323637: Capture hotspot replay files in GHA
• f368a0c: 8320328: Restore interrupted flag in ImageIcon.loadImage
• a45b5b4: 8323722: Serial: Remove unused no_gc_in_progress
• ... and 6 more: https://git.openjdk.org/jdk/compare/8643cc21333c6b51242ed3b9295b25f372244755...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

Thanks @lmesnik @shipilev for your reviews

/integrate

[openjdk]

Going to push as commit 5045839.
Since your change was applied there have been 22 commits pushed to the master branch:

• 44a9392: 8323780: Serial: Remove unused _full_collections_completed
• 5906240: 8323716: Only print ZGC Phase Switch events in hs_err files when running with ZGC
• e01f6da: 8320175: [BACKOUT] 8316533: C2 compilation fails with assert(verify(phase)) failed: missing Value() optimization
• 8abaf11: 8323715: Serial: Move genMemoryPools to serial folder
• 6720499: 8323738: Serial: Remove unreachable methods in Generation
• 36f4b34: 8323122: AArch64: Increase itable stub size estimate
• b363472: 8318227: RISC-V: C2 ConvHF2F
• edc0ebb: 8323745: Missing comma in copyright header in TestScope
• a03eb6d: 8321620: Optimize JImage decompressors
• f5b757c: 8323159: Consider adding some text re. memory zeroing in Arena::allocate
• ... and 12 more: https://git.openjdk.org/jdk/compare/8643cc21333c6b51242ed3b9295b25f372244755...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 5045839.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.