8323717: Introduce test keyword for tests that need external dependencies

[shipilev]

Some jtreg tests require resolvable external dependencies. This resolution is delegated to JIB, which is not used in vanilla OpenJDK testing. It would be convenient to add a keyword that marks tests that require these external dependencies, so that we could exclude those tests from runs. This would allow us to: a) run all tests in hotspot:tier4, which now excludes applications/ specifically; b) make all tests runs (#17422) cleaner on many environments.

I provisionally call this flag external-dep, but I am open for other suggestions.

Note that some tests that pull @Artifact-s provide special paths that do limited testing anyway. However, there are tests which cannot run without external dependencies at all. These include at least applications/jcstress and applications/scimark tests.

Ironically, I cannot run the jcstress test generator because the dependencies are lacking here. I regenerated those test using a self-built jcstress 0.16 bundle.

Additional testing:

• make test TEST=applications/ fails
• JTREG_KEYWORDS=\!external-dep make test TEST=applications/ passes, skipping most of the tests

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8323717: Introduce test keyword for tests that need external dependencies (Enhancement - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17421/head:pull/17421
$ git checkout pull/17421

Update a local copy of the PR:
$ git checkout pull/17421
$ git pull https://git.openjdk.org/jdk.git pull/17421/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17421

View PR using the GUI difftool:
$ git pr show -t 17421

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17421.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (727c6c52)

[shipilev]

Any takers? Maybe the audience should include core-libs too.

/label add core-libs

[openjdk]

@shipilev
The core-libs label was successfully added.

[dholmes-ora]

Seems quite reasonable.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323717: Introduce test keyword for tests that need external dependencies

Reviewed-by: dholmes, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 236 new commits pushed to the master branch:

• 6212264: 8320692: Null icon returned for .exe without custom icon
• 32eb529: 8324553: Shenandoah: Move periodic tasks closer to their collaborators
• c702dca: 8323815: Source launcher should find classes with $ in names
• c432dc0: 8322149: ConcurrentHashMap smarter presizing for copy constructor and putAll
• fb822e4: 8324514: ClassLoaderData::print_on should print address of class loader
• 00bb6bf: 8324220: jdk/jfr/event/io/TestSerializationMisdeclarationEvent.java had 22 failures
• bccd823: 8324613: Serial: Rename GenerationPool to TenuredGenerationPool
• 8c003d8: 8321512: runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java fails on 32-bit platforms
• 67f29b1: 8324537: Remove superfluous _FILE_OFFSET_BITS=64
• 1c1cb04: 8324512: Serial: Remove Generation::Name
• ... and 226 more: https://git.openjdk.org/jdk/compare/387828a3f7e4ec5b26954747e756aac212d579ae...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Seems quite reasonable.

Thanks!

I shall wait for more reviewers, in case someone has an issue with external-dep as the flag name.

[RogerRiggs]

Is there any place to document the new keyword or its usage; it does not seem very discoverable just existing in the TEST.ROOT and some tests.

[shipilev]

Is there any place to document the new keyword or its usage; it does not seem very discoverable just existing in the TEST.ROOT and some tests.

I don't think there is a place to describe keywords, except in the relevant TEST.ROOT-s.

[shipilev]

@lmesnik, you good with the keyword name?

[lmesnik]

@lmesnik, you good with the keyword name?

Yes, I'm fine.

[shipilev]

Awesome, thanks.

/integrate

[openjdk]

Going to push as commit 12b89cd.
Since your change was applied there have been 247 commits pushed to the master branch:

• 746a086: 8306767: Concurrent repacking of extra data in MethodData is potentially unsafe
• ffe3bb6: 8324657: Intermittent OOME on exception message create
• e709842: 8324636: Serial: Remove Generation::block_is_obj
• 7a798d3: 8324598: use mem_unit when working with sysinfo memory and swap related information
• 6d36eb7: 8322768: Optimize non-subword vector compress and expand APIs for AVX2 target.
• 9d1a6d1: 8323645: Remove unused internal sun.net.www.protocol.jar.URLJarFileCallBack interface
• 3059c3b: 8324242: Avoid null check for OopHandle::ptr_raw()
• 929af9e: 8307788: vmTestbase/gc/gctests/LargeObjects/large003/TestDescription.java timed out
• e7fdac9: 8324280: RISC-V: Incorrect implementation in VM_Version::parse_satp_mode
• 3d32c46: 6503196: API doc for DecimalFormat::getMaximumIntegerDigits is unclear
• ... and 237 more: https://git.openjdk.org/jdk/compare/387828a3f7e4ec5b26954747e756aac212d579ae...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 12b89cd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.