-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8258073: x86_32 build broken after JDK-8257731 #1743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into |
|
@DamonFool The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
/issue add JDK-8258073 |
|
@DamonFool This issue is referenced in the PR title - it will now be updated. |
|
@DamonFool |
|
/label remove hotspot-compiler |
|
@DamonFool The |
|
@DamonFool |
|
/cc hotspot-runtime |
|
@DamonFool The |
|
Should be forwarded to hotspot-runtime |
iklam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial to me. Sorry for the breakage. I've added linux-x86 into my test matrix for similar changes in the future.
|
@DamonFool This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
Thanks @iklam for your review. |
|
@DamonFool Pushed as commit 8befc32. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
Please review the one-line change for x86_32 build fix.
Thanks.
Best regards,
Jie
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1743/head:pull/1743$ git checkout pull/1743