Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258073: x86_32 build broken after JDK-8257731 #1743

Closed
wants to merge 1 commit into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Dec 11, 2020

Hi all,

Please review the one-line change for x86_32 build fix.

Thanks.
Best regards,
Jie


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1743/head:pull/1743
$ git checkout pull/1743

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 11, 2020

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 11, 2020
@openjdk
Copy link

openjdk bot commented Dec 11, 2020

@DamonFool The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Dec 11, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 11, 2020

Webrevs

@DamonFool
Copy link
Member Author

/issue add JDK-8258073
/label add hotspot-runtime
/cc hotspot-runtime

@openjdk
Copy link

openjdk bot commented Dec 11, 2020

@DamonFool This issue is referenced in the PR title - it will now be updated.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Dec 11, 2020
@openjdk
Copy link

openjdk bot commented Dec 11, 2020

@DamonFool
The hotspot-runtime label was successfully added.

@DamonFool
Copy link
Member Author

/label remove hotspot-compiler

@openjdk
Copy link

openjdk bot commented Dec 11, 2020

@DamonFool The hotspot-runtime label was already applied.

@openjdk openjdk bot removed the hotspot-compiler hotspot-compiler-dev@openjdk.org label Dec 11, 2020
@openjdk
Copy link

openjdk bot commented Dec 11, 2020

@DamonFool
The hotspot-compiler label was successfully removed.

@DamonFool
Copy link
Member Author

/cc hotspot-runtime

@openjdk
Copy link

openjdk bot commented Dec 11, 2020

@DamonFool The hotspot-runtime label was already applied.

@DamonFool
Copy link
Member Author

Should be forwarded to hotspot-runtime

Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial to me. Sorry for the breakage. I've added linux-x86 into my test matrix for similar changes in the future.

@openjdk
Copy link

openjdk bot commented Dec 11, 2020

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258073: x86_32 build broken after JDK-8257731

Reviewed-by: iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 11, 2020
@DamonFool
Copy link
Member Author

Thanks @iklam for your review.
/integrate

@openjdk openjdk bot closed this Dec 11, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 11, 2020
@openjdk
Copy link

openjdk bot commented Dec 11, 2020

@DamonFool Pushed as commit 8befc32.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonFool DamonFool deleted the JDK-8258073 branch December 11, 2020 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants