8323694: RISC-V: Unnecessary ResourceMark in NativeCall::set_destination_mt_safe

[zifeihan]

Hi, We noticed that RISC-V bears a similar issue as: https://bugs.openjdk.org/browse/JDK-8323584.
In NativeCall::set_destination_mt_safe, there is a ResourceMark that does not seem to have any purpose: no code in its scope uses resource allocation.

Testing:

• Run tier1 tests on qemu 8.1.0 with UseRVV (fastdebug)
• Run tier1-3 tests on qemu 8.1.0 with UseRVV (release)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8323694: RISC-V: Unnecessary ResourceMark in NativeCall::set_destination_mt_safe (Enhancement - P4)

Reviewers

• Fei Yang (@RealFYang - Reviewer)
• Robbin Ehn (@robehn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17436/head:pull/17436
$ git checkout pull/17436

Update a local copy of the PR:
$ git checkout pull/17436
$ git pull https://git.openjdk.org/jdk.git pull/17436/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17436

View PR using the GUI difftool:
$ git pr show -t 17436

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17436.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@zifeihan The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (20a3a7ca)

[openjdk]

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323694: RISC-V: Unnecessary ResourceMark in NativeCall::set_destination_mt_safe

Reviewed-by: fyang, rehn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

• dadd9cd: 8316497: ColorConvertOp - typo for non-ICC conversions needs one-line fix
• de237fb: 8323554: The typos in Javadoc: "@return if "
• 51dbd36: 8322100: Fix GCMIncrementByte4 & GCMIncrementDirect4, and increase overlap testing
• ffa33d7: 8317771: [macos14] Expand/collapse a JTree using keyboard freezes the application in macOS 14 Sonoma
• 4e53235: 8323710: (fc) FileChannel.lock creates a FileKey with a poor hashCode after JDK-8321429 (win)
• 19287ee: 8321561: (fs) Clarify non-atomic behavior of Files.move
• 8b29e12: 8323794: Remove unused jimage compressor plugin configuration
• 7be9f1d: 8321137: Reconsider ICStub alignment
• b8dafa6: 8323612: IOVecWrapper should be changed to be TerminatingThreadLocal
• f2a4ed6: 8323779: Serial: Remove Generation::promotion_attempt_is_safe
• ... and 32 more: https://git.openjdk.org/jdk/compare/b3634722655901b8d3e43dd1f8aa2b4487509a34...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang, @robehn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[robehn]

Thanks!

[zifeihan]

@RealFYang @robehn : Thanks for the review.
/integrate

[openjdk]

@zifeihan
Your change (at version 20a3a7c) is now ready to be sponsored by a Committer.

[RealFYang]

/sponsor

[openjdk]

Going to push as commit ff8cc26.
Since your change was applied there have been 42 commits pushed to the master branch:

• dadd9cd: 8316497: ColorConvertOp - typo for non-ICC conversions needs one-line fix
• de237fb: 8323554: The typos in Javadoc: "@return if "
• 51dbd36: 8322100: Fix GCMIncrementByte4 & GCMIncrementDirect4, and increase overlap testing
• ffa33d7: 8317771: [macos14] Expand/collapse a JTree using keyboard freezes the application in macOS 14 Sonoma
• 4e53235: 8323710: (fc) FileChannel.lock creates a FileKey with a poor hashCode after JDK-8321429 (win)
• 19287ee: 8321561: (fs) Clarify non-atomic behavior of Files.move
• 8b29e12: 8323794: Remove unused jimage compressor plugin configuration
• 7be9f1d: 8321137: Reconsider ICStub alignment
• b8dafa6: 8323612: IOVecWrapper should be changed to be TerminatingThreadLocal
• f2a4ed6: 8323779: Serial: Remove Generation::promotion_attempt_is_safe
• ... and 32 more: https://git.openjdk.org/jdk/compare/b3634722655901b8d3e43dd1f8aa2b4487509a34...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealFYang @zifeihan Pushed as commit ff8cc26.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.