8323779: Serial: Remove Generation::promotion_attempt_is_safe

[albertnetymk]

Simple updating a field type to use more concrete type.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8323779: Serial: Remove Generation::promotion_attempt_is_safe (Enhancement - P4)

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Chris Plummer (@plummercj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17439/head:pull/17439
$ git checkout pull/17439

Update a local copy of the PR:
$ git checkout pull/17439
$ git pull https://git.openjdk.org/jdk.git pull/17439/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17439

View PR using the GUI difftool:
$ git pr show -t 17439

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17439.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (2a0318e3)
• 00: Full (36e85243)

[stefank]

The alignment in this block is weird after this change.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323779: Serial: Remove Generation::promotion_attempt_is_safe

Reviewed-by: stefank, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 1007618: 8323731: Unproblemlist gc/stress/TestStressG1Humongous.java
• 790871e: 8323800: Serial: Fix include guard macro in generation.hpp
• 0216f5d: 8323730: Tweak TestZAllocationStallEvent.java to allocate smaller objects
• 21f6473: 8322675: JFR: Fail-fast mode when constants cannot be resolved
• e2d6023: 8323631: JfrTypeSet::write_klass can enqueue a CLD klass that is unloading
• 2fd775f: 8323651: compiler/c2/irTests/TestPrunedExHandler.java fails with -XX:+DeoptimizeALot
• ee4d9aa: 8323659: LinkedTransferQueue add and put methods call overridable offer
• 5045839: 8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3
• 44a9392: 8323780: Serial: Remove unused _full_collections_completed
• 5906240: 8323716: Only print ZGC Phase Switch events in hs_err files when running with ZGC
• ... and 1 more: https://git.openjdk.org/jdk/compare/8abaf119659e46684d196bf76784c11587039f60...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[plummercj]

SA changes look good. Make sure you test SA with -XX:+SerialGC.

[albertnetymk]

Thanks for review.

/integrate

[openjdk]

Going to push as commit f2a4ed6.
Since your change was applied there have been 29 commits pushed to the master branch:

• 22642ff: 8319382: com/sun/jdi/JdwpAllowTest.java shows failures on AIX if prefixLen of mask is larger than 32 in IPv6 case
• b891721: 8316756: C2 EA fails with "missing memory path" when encountering unsafe_arraycopy stub call
• bf666bc: 8322692: ZGC: avoid over-unrolling due to hidden barrier size
• de97c0e: 8290965: PPC64: Implement post-call NOPs
• f70667e: 8318112: CSS percentage values are capped at 100%
• 2063bb8: Merge
• bf7bd9a: 8317547: Enhance TLS connection support
• c1a568c: 8314307: Improve loop handling
• 1cc6fbd: 8318588: Windows build failure after JDK-8314468 due to ambiguous call
• ed238e8: 8314468: Improve Compiler loops
• ... and 19 more: https://git.openjdk.org/jdk/compare/8abaf119659e46684d196bf76784c11587039f60...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit f2a4ed6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.