Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8323835: Updating ASM to 9.6 for JDK 23 #17453

Closed

Conversation

vicente-romero-oracle
Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle commented Jan 16, 2024

Updating ASM to version 9.6,

Thanks in advance for the reviews,
Vicente


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8323835: Updating ASM to 9.6 for JDK 23 (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17453/head:pull/17453
$ git checkout pull/17453

Update a local copy of the PR:
$ git checkout pull/17453
$ git pull https://git.openjdk.org/jdk.git pull/17453/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17453

View PR using the GUI difftool:
$ git pr show -t 17453

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17453.diff

Webrev

Link to Webrev Comment

@vicente-romero-oracle vicente-romero-oracle marked this pull request as draft January 16, 2024 21:19
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 16, 2024

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 16, 2024

@vicente-romero-oracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 16, 2024
@vicente-romero-oracle vicente-romero-oracle marked this pull request as ready for review January 17, 2024 15:53
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 17, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 17, 2024

Webrevs

@mlchung
Copy link
Member

mlchung commented Jan 22, 2024

The change looks okay to me. Most of the changes are doc change. I see many files are updated just to remove the empty line at the end of the file - is that intentional, imported from this upgrade?

Any need to update the copyright header? The new file CheckFrameAnalyzer.java still has the same copyright header years as other files. I assume no need then?

@vicente-romero-oracle
Copy link
Contributor Author

hi Mandy, thanks for your comments,

The change looks okay to me. Most of the changes are doc change. I see many files are updated just to remove the empty line at the end of the file - is that intentional, imported from this upgrade?

yes this is intentional, this change somehow aligns with what we do with our sources that's why I kept it

Any need to update the copyright header? The new file CheckFrameAnalyzer.java still has the same copyright header years as other files. I assume no need then?

yes there is no need to update them, we never update the year on the copyright of ASM sources

Copy link
Member

@mlchung mlchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me. I would rely on your testing for verification.

@openjdk
Copy link

openjdk bot commented Jan 26, 2024

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323835: Updating ASM to 9.6 for JDK 23

Reviewed-by: mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 112 new commits pushed to the master branch:

  • b5995a7: 8302019: Clarify Elements.overrides
  • 95310ea: 8223696: java/net/httpclient/MaxStreams.java failed with didn't finish within the time-out
  • 39b756a: 8324492: Remove Atomic support for OopHandle
  • 12b89cd: 8323717: Introduce test keyword for tests that need external dependencies
  • 746a086: 8306767: Concurrent repacking of extra data in MethodData is potentially unsafe
  • ffe3bb6: 8324657: Intermittent OOME on exception message create
  • e709842: 8324636: Serial: Remove Generation::block_is_obj
  • 7a798d3: 8324598: use mem_unit when working with sysinfo memory and swap related information
  • 6d36eb7: 8322768: Optimize non-subword vector compress and expand APIs for AVX2 target.
  • 9d1a6d1: 8323645: Remove unused internal sun.net.www.protocol.jar.URLJarFileCallBack interface
  • ... and 102 more: https://git.openjdk.org/jdk/compare/19c9388c2001b7b3d21624e2dd4ab4fdd8821e2f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 26, 2024
@vicente-romero-oracle
Copy link
Contributor Author

vicente-romero-oracle commented Jan 26, 2024

Looks okay to me. I would rely on your testing for verification.

Thanks for your review! Yep all tests look OK

@vicente-romero-oracle
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 26, 2024

Going to push as commit 91d8ea7.
Since your change was applied there have been 121 commits pushed to the master branch:

  • a65a895: 8315923: pretouch_memory by atomic-add-0 fragments huge pages unexpectedly
  • 62b3293: 8324241: Always record evol_method deps to avoid excessive method flushing
  • 885e9b7: 8324722: Serial: Inline block_is_obj of subclasses of Generation
  • 32ddcf5: 8324301: Obsolete MaxGCMinorPauseMillis
  • c313d45: 8324659: GHA: Generic jtreg errors are not reported
  • 781f368: 8324347: Enable "maybe-uninitialized" warning for FreeType 2.13.1
  • 33324a5: 8324637: [aix] Implement support for reporting swap space in jdk.management
  • 10066cd: 8324571: JDK 23 L10n resource files update
  • bde8789: 8324123: aarch64: fix prfm literal encoding in assembler
  • b5995a7: 8302019: Clarify Elements.overrides
  • ... and 111 more: https://git.openjdk.org/jdk/compare/19c9388c2001b7b3d21624e2dd4ab4fdd8821e2f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 26, 2024
@openjdk openjdk bot closed this Jan 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 26, 2024
@openjdk
Copy link

openjdk bot commented Jan 26, 2024

@vicente-romero-oracle Pushed as commit 91d8ea7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants