Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258074: Move some flags related to compiler to compiler_globals.hpp #1746

Closed
wants to merge 3 commits into from

Conversation

iklam
Copy link
Member

@iklam iklam commented Dec 11, 2020

Many flags in globals.hpp are related to the compiler, and are mostly used only by the compiler source files. These flags should be moved to compiler_globals.hpp

Examples:

  • CompileCommandFile
  • Tier2CompileThreshold
  • HugeMethodLimit

This speeds up HotSpot build time, and improves modularity.

This RFE is the first step -- it moves a few dozen flags that are straight-forward to move. Other flags may be moved by follow-up RFEs.

Tested with mach5: tier1, builds-tier2, builds-tier3, builds-tier4 and builds-tier5 on mach5, plus locally building arm, aarch64, s390, ppc64, and zero.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258074: Move some flags related to compiler to compiler_globals.hpp

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1746/head:pull/1746
$ git checkout pull/1746

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 11, 2020

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 11, 2020

@iklam The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Dec 11, 2020
@iklam iklam marked this pull request as ready for review Dec 11, 2020
@openjdk openjdk bot added the rfr label Dec 11, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 11, 2020

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Good.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 11, 2020

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258074: Move some flags related to compiler to compiler_globals.hpp

Reviewed-by: kvn, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 47ba652: 8258455: problem list tools/jdeprscan/tests/jdk/jdeprscan/TestRelease.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 11, 2020
Copy link
Contributor

@coleenp coleenp left a comment

Very nice!

@iklam
Copy link
Member Author

@iklam iklam commented Dec 16, 2020

Thanks @vnkozlov and @coleenp for the review.
/integrate

@openjdk openjdk bot closed this Dec 16, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 16, 2020

@iklam Since your change was applied there has been 1 commit pushed to the master branch:

  • 47ba652: 8258455: problem list tools/jdeprscan/tests/jdk/jdeprscan/TestRelease.java

Your commit was automatically rebased without conflicts.

Pushed as commit 17ace83.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot integrated
3 participants