Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315762: Update subtype check profile collection on s390x following 8308869 #17461

Closed
wants to merge 2 commits into from

Conversation

offamitkumar
Copy link
Member

@offamitkumar offamitkumar commented Jan 17, 2024

s390x Implementation for #14375

Benchmark Result with patch:

Benchmark                                         (typePollution)  (typePollutionNotInternalType)   Mode  Cnt     Score    Error   Units
RequireNonNullCheckcastScalability.isDuplicated1            false                           false  thrpt   20  1155.409 ± 43.844  ops/us
RequireNonNullCheckcastScalability.isDuplicated1            false                            true  thrpt   20   726.923 ± 54.536  ops/us
RequireNonNullCheckcastScalability.isDuplicated1             true                           false  thrpt   20   676.462 ± 23.503  ops/us
RequireNonNullCheckcastScalability.isDuplicated1             true                            true  thrpt   20   118.650 ±  2.653  ops/us

Without Patch:

Benchmark                                         (typePollution)  (typePollutionNotInternalType)   Mode  Cnt     Score     Error   Units
RequireNonNullCheckcastScalability.isDuplicated1            false                           false  thrpt   20  1101.248 ± 103.559  ops/us
RequireNonNullCheckcastScalability.isDuplicated1            false                            true  thrpt   20   109.690 ±   3.312  ops/us
RequireNonNullCheckcastScalability.isDuplicated1             true                           false  thrpt   20   110.790 ±   7.927  ops/us
RequireNonNullCheckcastScalability.isDuplicated1             true                            true  thrpt   20   112.244 ±   6.889  ops/us

Testing : Fastdebug build + tier1 tests


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315762: Update subtype check profile collection on s390x following 8308869 (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17461/head:pull/17461
$ git checkout pull/17461

Update a local copy of the PR:
$ git checkout pull/17461
$ git pull https://git.openjdk.org/jdk.git pull/17461/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17461

View PR using the GUI difftool:
$ git pr show -t 17461

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17461.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 17, 2024

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8315750 8315750: Update subtype check profile collection on PPC following 8308869 Jan 17, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 17, 2024
@openjdk
Copy link

openjdk bot commented Jan 17, 2024

@offamitkumar The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jan 17, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 17, 2024

Webrevs

@offamitkumar offamitkumar changed the title 8315750: Update subtype check profile collection on PPC following 8308869 8315762 Jan 17, 2024
@openjdk openjdk bot changed the title 8315762 8315762: Update subtype check profile collection on s390x following 8308869 Jan 17, 2024
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct AFAICS. Please make sure it is thoroughly tested before integrating. Especially the C1 code is sensitive to register clashes which may cause errors which are very hard to debug.

@openjdk
Copy link

openjdk bot commented Jan 24, 2024

@offamitkumar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315762: Update subtype check profile collection on s390x following 8308869

Reviewed-by: mdoerr, lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • a65a895: 8315923: pretouch_memory by atomic-add-0 fragments huge pages unexpectedly
  • 62b3293: 8324241: Always record evol_method deps to avoid excessive method flushing
  • 885e9b7: 8324722: Serial: Inline block_is_obj of subclasses of Generation
  • 32ddcf5: 8324301: Obsolete MaxGCMinorPauseMillis
  • c313d45: 8324659: GHA: Generic jtreg errors are not reported
  • 781f368: 8324347: Enable "maybe-uninitialized" warning for FreeType 2.13.1
  • 33324a5: 8324637: [aix] Implement support for reporting swap space in jdk.management
  • 10066cd: 8324571: JDK 23 L10n resource files update
  • bde8789: 8324123: aarch64: fix prfm literal encoding in assembler
  • b5995a7: 8302019: Clarify Elements.overrides
  • ... and 4 more: https://git.openjdk.org/jdk/compare/ffe3bb67632eeec4b5df4e832d9bd5e78c3f808a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 24, 2024
Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please ensure proper testing, as Martin requested. Running tests with -XX:TierStopAtLevel=3 (effectively turning off C2) might be a good idea.

@offamitkumar
Copy link
Member Author

Please ensure proper testing, as Martin requested. Running tests with -XX:TierStopAtLevel=3 (effectively turning off C2) might be a good idea.

I performed the test again and saw few failures with & without my patch. When I checked the log, they were either failing due to

  1. timeout
  2. result: Failed. Execution failed: `main' threw exception: java.lang.VirtualMachineError: Out of space in CodeCache for method handle intrinsic

Should all test pass even with -XX:TieredStopAtLevel=3, Because these were failing in master branch as well ?

@TheRealMDoerr
Copy link
Contributor

Such kind of test errors are expected when using -XX:TieredStopAtLevel=3. So, if you have also run the jtreg test suite with normal settings, that should be ok.

@offamitkumar
Copy link
Member Author

So, if you have also run the jtreg test suite with normal settings, that should be ok.

I didn't get new test failure in jtreg, do let me know If anything else you want me to run test for. Otherwise I'll integrate it today.

@TheRealMDoerr
Copy link
Contributor

It's up to you to test as much as you can.

@offamitkumar
Copy link
Member Author

I ran the test again and didn't see new failure. So moving ahead with integration.
Thanks @RealLucy @TheRealMDoerr for the reviews.

/integrate

@openjdk
Copy link

openjdk bot commented Feb 5, 2024

Going to push as commit 8796f43.
Since your change was applied there have been 99 commits pushed to the master branch:

  • 80642dd: 8324817: Parallel GC does not pre-touch all heap pages when AlwaysPreTouch enabled and large page disabled
  • 692c9f8: 8325201: (zipfs) Disable TestPosix.setPermissionsShouldConvertToUnix which fails on Windows
  • ed06846: 8325037: x86: enable and fix hotspot/jtreg/compiler/vectorization/TestRoundVectFloat.java
  • a18b03b: 8324635: (zipfs) Regression in Files.setPosixFilePermissions called on existing MSDOS entries
  • 7476e29: 8323680: SA PointerFinder code can do a better job of leveraging existing code to determine if an address is in the TLAB
  • 63cb1f8: 8321396: Retire test/jdk/java/util/zip/NoExtensionSignature.java
  • f613e13: 8313739: ZipOutputStream.close() should always close the wrapped stream
  • adc3604: 8325148: Enable restricted javac warning in java.base
  • 1ae8513: 8324858: [vectorapi] Bounds checking issues when accessing memory segments
  • 38c0197: 8318105: [jmh] the test java.security.HSS failed with 2 active threads
  • ... and 89 more: https://git.openjdk.org/jdk/compare/ffe3bb67632eeec4b5df4e832d9bd5e78c3f808a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 5, 2024
@openjdk openjdk bot closed this Feb 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 5, 2024
@openjdk
Copy link

openjdk bot commented Feb 5, 2024

@offamitkumar Pushed as commit 8796f43.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@offamitkumar offamitkumar deleted the subtype_v0 branch May 15, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants