8323502: javac crash with wrongly typed method block in Flow

[biboudis]

The observation is that the tree.target of the RHS's yield was not set properly to point at the outer switch. As a result, the assertion was hit in clearPendingExits with a wrong set of pending exits.

The cause was that the tree was not attributed since visitSwitchExpression was short-circuited to return; and visitYield was never setting the target. As a result, resolveJump was not actually resolving the jump correctly.

thx @lahodaj for the help!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8323502: javac crash with wrongly typed method block in Flow (Bug - P4)

Reviewers

• Jan Lahoda (@lahodaj - Reviewer)

Contributors

• Jan Lahoda <jlahoda@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17466/head:pull/17466
$ git checkout pull/17466

Update a local copy of the PR:
$ git checkout pull/17466
$ git pull https://git.openjdk.org/jdk.git pull/17466/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17466

View PR using the GUI difftool:
$ git pr show -t 17466

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17466.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back abimpoudis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[biboudis]

/contributor add lahodaj

[openjdk]

@biboudis lahodaj was not found in the census.

Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

• /contributor add @openjdk-bot
• /contributor add duke
• /contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

[openjdk]

@biboudis The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[biboudis]

/contributor add @lahodaj

[openjdk]

@biboudis
Contributor Jan Lahoda <jlahoda@openjdk.org> successfully added.

[mlbridge]

Webrevs

• 00: Full (e441c17d)

[lahodaj]

To me, looks good.

[openjdk]

@biboudis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323502: javac crash with wrongly typed method block in Flow

Co-authored-by: Jan Lahoda <jlahoda@openjdk.org>
Reviewed-by: jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 232 new commits pushed to the master branch:

• af32262: 8325049: stubGenerator_ppc.cpp should use alignas
• 85e3201: 8325159: C2 SuperWord: measure time for CITime
• 8796f43: 8315762: Update subtype check profile collection on s390x following 8308869
• 80642dd: 8324817: Parallel GC does not pre-touch all heap pages when AlwaysPreTouch enabled and large page disabled
• 692c9f8: 8325201: (zipfs) Disable TestPosix.setPermissionsShouldConvertToUnix which fails on Windows
• ed06846: 8325037: x86: enable and fix hotspot/jtreg/compiler/vectorization/TestRoundVectFloat.java
• a18b03b: 8324635: (zipfs) Regression in Files.setPosixFilePermissions called on existing MSDOS entries
• 7476e29: 8323680: SA PointerFinder code can do a better job of leveraging existing code to determine if an address is in the TLAB
• 63cb1f8: 8321396: Retire test/jdk/java/util/zip/NoExtensionSignature.java
• f613e13: 8313739: ZipOutputStream.close() should always close the wrapped stream
• ... and 222 more: https://git.openjdk.org/jdk/compare/c84c0ab52d5e08a693f7ad7d9a4772d8c1eeeaa8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[biboudis]

/integrate

[openjdk]

Going to push as commit df35462.
Since your change was applied there have been 232 commits pushed to the master branch:

• af32262: 8325049: stubGenerator_ppc.cpp should use alignas
• 85e3201: 8325159: C2 SuperWord: measure time for CITime
• 8796f43: 8315762: Update subtype check profile collection on s390x following 8308869
• 80642dd: 8324817: Parallel GC does not pre-touch all heap pages when AlwaysPreTouch enabled and large page disabled
• 692c9f8: 8325201: (zipfs) Disable TestPosix.setPermissionsShouldConvertToUnix which fails on Windows
• ed06846: 8325037: x86: enable and fix hotspot/jtreg/compiler/vectorization/TestRoundVectFloat.java
• a18b03b: 8324635: (zipfs) Regression in Files.setPosixFilePermissions called on existing MSDOS entries
• 7476e29: 8323680: SA PointerFinder code can do a better job of leveraging existing code to determine if an address is in the TLAB
• 63cb1f8: 8321396: Retire test/jdk/java/util/zip/NoExtensionSignature.java
• f613e13: 8313739: ZipOutputStream.close() should always close the wrapped stream
• ... and 222 more: https://git.openjdk.org/jdk/compare/c84c0ab52d5e08a693f7ad7d9a4772d8c1eeeaa8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@biboudis Pushed as commit df35462.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.