Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8159927: Add a test to verify JMOD files created in the images do not have debug symbols #17467

Closed
wants to merge 1 commit into from

Conversation

mlchung
Copy link
Member

@mlchung mlchung commented Jan 17, 2024

The build excludes the native debug symbols in JMOD files created for JDK modules (see make/CreateJmods.gmk). This PR adds a test to verify that native debug symbols are excluded as expected.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8159927: Add a test to verify JMOD files created in the images do not have debug symbols (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17467/head:pull/17467
$ git checkout pull/17467

Update a local copy of the PR:
$ git checkout pull/17467
$ git pull https://git.openjdk.org/jdk.git pull/17467/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17467

View PR using the GUI difftool:
$ git pr show -t 17467

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17467.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 17, 2024

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 17, 2024
@openjdk
Copy link

openjdk bot commented Jan 17, 2024

@mlchung The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 17, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 17, 2024

Webrevs

Copy link
Member

@JimLaskey JimLaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Jan 18, 2024

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8159927: Add a test to verify JMOD files created in the images do not have debug symbols

Reviewed-by: jlaskey

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • bfd2afe: 8275338: Add JFR events for notable serialization situations
  • 4c1a0fc: 8323995: Suppress notes generated on incremental microbenchmark builds
  • a2b117a: 8324132: G1: Remove unimplemented G1MonitoringSupport::recalculate_eden_size
  • 8e53459: 8323993: Serial: Refactor gc_prologue and gc_epilogue
  • aeb304b: 8324074: increase timeout for jvmci test TestResolvedJavaMethod.java
  • a22ae90: 8321938: java/foreign/critical/TestCriticalUpcall.java does not need a core file
  • 806ffb1: 8324082: more monitoring test timeout adjustments
  • 52f787f: 8323595: is_aligned(p, alignof(OopT))) assertion fails in Jetty without compressed OOPs
  • cbfddf4: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination
  • 57fad67: 8323667: Library debug files contain non-reproducible full gcc include paths
  • ... and 3 more: https://git.openjdk.org/jdk/compare/51dbd36c74c70b1b17bd73cd2c3253593300b5f0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 18, 2024
@mlchung
Copy link
Member Author

mlchung commented Jan 19, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jan 19, 2024

Going to push as commit 6c0bebc.
Since your change was applied there have been 27 commits pushed to the master branch:

  • 437342b: 8323556: CDS archive space addresses should be randomized with ArchiveRelocationMode=1
  • 39005e2: 8324041: ModuleOption.java failed with update release versioning scheme
  • 2865afe: 8323685: PrintSystemDictionaryAtExit has mutex rank assert
  • 6997bfc: 8323154: C2: assert(cmp != nullptr && cmp->Opcode() == Op_Cmp(bt)) failed: no exit test
  • 16be388: 8322383: G1: Only preserve marks on objects that are actually moved
  • 0081d8c: 8324147: Serial: Remove generation::compute_new_size
  • 5f71419: 8322366: Add IEEE rounding mode corruption check to JNI checks
  • 0533022: 8222719: libperfstat on AIX - cleanup old API versions
  • 05dad67: 8295804: javax/swing/JFileChooser/JFileChooserSetLocationTest.java failed with "setLocation() is not working properly"
  • 9efdd24: 8324053: Use the blessed modifier order for sealed in java.base
  • ... and 17 more: https://git.openjdk.org/jdk/compare/51dbd36c74c70b1b17bd73cd2c3253593300b5f0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 19, 2024
@openjdk openjdk bot closed this Jan 19, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 19, 2024
@openjdk
Copy link

openjdk bot commented Jan 19, 2024

@mlchung Pushed as commit 6c0bebc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlchung mlchung deleted the JDK-8159927 branch February 22, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants