-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8324053: Use the blessed modifier order for sealed in java.base #17468
Conversation
👋 Welcome back prappo! A progress list of the required criteria for merging this PR into |
@pavelrappo The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
@pavelrappo This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! When this has been integrated, I can take a shot at the missorted default
s.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks, I could've done that myself, but decided not to. You see, Whatever you decide to do, be prepared to work manually. |
/integrate |
Going to push as commit 9efdd24.
Your commit was automatically rebased without conflicts. |
@pavelrappo Pushed as commit 9efdd24. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this trivial PR to reorder the
sealed
class or interface modifier. For context of this change see: #17242 (comment).Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17468/head:pull/17468
$ git checkout pull/17468
Update a local copy of the PR:
$ git checkout pull/17468
$ git pull https://git.openjdk.org/jdk.git pull/17468/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 17468
View PR using the GUI difftool:
$ git pr show -t 17468
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17468.diff
Webrev
Link to Webrev Comment