8323994: gtest runner repeats test name for every single gtest assertion #17489

SoniaZaldana · 2024-01-18T16:35:35Z

If GTest fails multiple times within the same test (for example when EXPECT or ASSERT are used in a subroutine), GTestResultParser repeats the failing test multiple times in its report.

Please refer to the existing issue for an example.

We only need to see the failing test reported once, so this patch fixes that.

Let me know your thoughts.
Cheers,
Sonia

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8323994: gtest runner repeats test name for every single gtest assertion (Bug - P4)

Reviewers

Thomas Stuefe (@tstuefe - Reviewer) ⚠️ Review applies to 279fb7d0
Leonid Mesnik (@lmesnik - Reviewer) ⚠️ Review applies to 279fb7d0

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17489/head:pull/17489
$ git checkout pull/17489

Update a local copy of the PR:
$ git checkout pull/17489
$ git pull https://git.openjdk.org/jdk.git pull/17489/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17489

View PR using the GUI difftool:
$ git pr show -t 17489

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17489.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-01-18T16:36:50Z

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-01-18T16:38:36Z

@SoniaZaldana To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

build
client
compiler
core-libs
graal
hotspot
hotspot-compiler
hotspot-gc
hotspot-jfr
hotspot-runtime
i18n
ide-support
javadoc
jdk
jmx
kulla
net
nio
security
serviceability
shenandoah

tstuefe

Good. Thanks for fixing.

tstuefe · 2024-01-24T14:59:23Z

/label hotspot-runtime

openjdk · 2024-01-24T14:59:50Z

@SoniaZaldana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323994: gtest runner repeats test name for every single gtest assertion

Reviewed-by: stuefe, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 287 new commits pushed to the master branch:

c266800: 8325558: Add jcheck whitespace checking for properties files
ec20b0a: 8325626: Allow selection of non-matching configurations using CONF=!string
618af39: 8325633: Use stricter assertion in callers of Space::is_aligned
5dbf137: 8319797: Recursive lightweight locking: Runtime implementation
4513da9: 8325470: [AIX] use fclose after fopen in read_psinfo
62a4be0: 8325635: Serial: Inline verify_used_region_at_save_marks
b356fee: 8325458: Rename mlvmJvmtiUtils.h
2ed889b: 8323628: Update license on "pass-through" files
7c69712: 8325570: Update to Graphviz 9.0.0
482c100: 8322865: JavaDoc fails on aggregator modules
... and 277 more: https://git.openjdk.org/jdk/compare/aeb304b29eaaba2b7a8fef85ee46cbfca27dbfbe...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tstuefe, @lmesnik) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2024-01-24T14:59:56Z

@tstuefe
The hotspot-runtime label was successfully added.

mlbridge · 2024-01-24T15:02:46Z

Webrevs

01: Full - Incremental (765f826d)
00: Full (279fb7d0)

SoniaZaldana · 2024-01-24T15:06:06Z

/integrate

openjdk · 2024-01-24T15:06:21Z

@SoniaZaldana
Your change (at version 279fb7d) is now ready to be sponsored by a Committer.

tstuefe · 2024-01-24T19:24:24Z

Let's wait for a second review (need two in hotspot territory) snd the obligatory 24 hrs.

/reviewer 2

openjdk · 2024-01-24T19:25:11Z

@tstuefe Only the author (@SoniaZaldana) is allowed to issue the reviewer command.

lmesnik

Please remove space and update copyrights. Otherwise fix looks good.

lmesnik · 2024-01-24T22:41:24Z

test/hotspot/jtreg/gtest/GTestResultParser.java

@@ -57,7 +57,10 @@ public GTestResultParser(Path file) {
                            testCase = xmlReader.getAttributeValue("", "name");
                            break;
                        case "failure":
-                            failedTests.add(testSuite + "::" + testCase);
+                            String failedStr = testSuite + "::" + testCase;
+                            if (! failedTests.contains(failedStr)) {


Please remove space between '! and failed..'.

Thanks @lmesnik! I pushed the changes.

tstuefe

Still good. Ship it.

tstuefe · 2024-02-06T07:03:56Z

@SoniaZaldana you need to newly slash integrate.

SoniaZaldana · 2024-02-12T14:21:41Z

/integrate

openjdk · 2024-02-12T14:22:13Z

@SoniaZaldana
Your change (at version 765f826) is now ready to be sponsored by a Committer.

tstuefe · 2024-02-15T08:02:35Z

/sponsor

openjdk · 2024-02-15T08:03:02Z

Going to push as commit 1aae980.
Since your change was applied there have been 319 commits pushed to the master branch:

810daf8: 8325910: Rename jnihelper.h
22e8181: 8325682: Rename nsk_strace.h
b823fa4: 8325574: Shenandoah: Simplify and enhance reporting of requested GCs
09d4936: 8252136: Several methods in hotspot are missing "static"
f6e2851: 8316340: (bf) Missing {@inheritdoc} for exception in MappedByteBuffer::compact
53878ee: 8325643: G1: Refactor G1FlushHumongousCandidateRemSets
130f429: 8325403: Add SystemGC JMH benchmarks
9c852df: 8318966: Some methods make promises about Java array element alignment that are too strong
737b4c5: 8323883: JFR AssertionError: Missing object ID 15101
61f2493: 8325767: Serial: Move transform_stack_chunk out of TenuredGeneration::promote
... and 309 more: https://git.openjdk.org/jdk/compare/aeb304b29eaaba2b7a8fef85ee46cbfca27dbfbe...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-02-15T08:03:11Z

@tstuefe @SoniaZaldana Pushed as commit 1aae980.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8323994: gtest runner repeats test name for every single gtest assertion

279fb7d

SoniaZaldana marked this pull request as ready for review January 24, 2024 14:11

openjdk bot added the rfr Pull request is ready for review label Jan 24, 2024

tstuefe approved these changes Jan 24, 2024

View reviewed changes

openjdk bot added ready Pull request is ready to be integrated hotspot-runtime hotspot-runtime-dev@openjdk.org labels Jan 24, 2024

openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 24, 2024

lmesnik approved these changes Jan 24, 2024

View reviewed changes

Fixing copyright header and spacing issue

765f826

openjdk bot removed the sponsor Pull request is ready to be sponsored label Jan 25, 2024

tstuefe reviewed Jan 25, 2024

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 12, 2024

openjdk bot added the integrated Pull request has been integrated label Feb 15, 2024

openjdk bot closed this Feb 15, 2024

openjdk bot removed the ready Pull request is ready to be integrated label Feb 15, 2024

openjdk bot removed rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8323994: gtest runner repeats test name for every single gtest assertion #17489

8323994: gtest runner repeats test name for every single gtest assertion #17489

SoniaZaldana commented Jan 18, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Jan 18, 2024

openjdk bot commented Jan 18, 2024

tstuefe left a comment

tstuefe commented Jan 24, 2024

openjdk bot commented Jan 24, 2024 •

edited

Loading

openjdk bot commented Jan 24, 2024

mlbridge bot commented Jan 24, 2024 •

edited

Loading

SoniaZaldana commented Jan 24, 2024

openjdk bot commented Jan 24, 2024

tstuefe commented Jan 24, 2024

openjdk bot commented Jan 24, 2024

lmesnik left a comment

lmesnik Jan 24, 2024

SoniaZaldana Jan 25, 2024

tstuefe left a comment

tstuefe commented Feb 6, 2024

SoniaZaldana commented Feb 12, 2024

openjdk bot commented Feb 12, 2024

tstuefe commented Feb 15, 2024

openjdk bot commented Feb 15, 2024

openjdk bot commented Feb 15, 2024

8323994: gtest runner repeats test name for every single gtest assertion #17489

8323994: gtest runner repeats test name for every single gtest assertion #17489

Conversation

SoniaZaldana commented Jan 18, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Jan 18, 2024

openjdk bot commented Jan 18, 2024

tstuefe left a comment

Choose a reason for hiding this comment

tstuefe commented Jan 24, 2024

openjdk bot commented Jan 24, 2024 • edited Loading

openjdk bot commented Jan 24, 2024

mlbridge bot commented Jan 24, 2024 • edited Loading

Webrevs

SoniaZaldana commented Jan 24, 2024

openjdk bot commented Jan 24, 2024

tstuefe commented Jan 24, 2024

openjdk bot commented Jan 24, 2024

lmesnik left a comment

Choose a reason for hiding this comment

lmesnik Jan 24, 2024

Choose a reason for hiding this comment

SoniaZaldana Jan 25, 2024

Choose a reason for hiding this comment

tstuefe left a comment

Choose a reason for hiding this comment

tstuefe commented Feb 6, 2024

SoniaZaldana commented Feb 12, 2024

openjdk bot commented Feb 12, 2024

tstuefe commented Feb 15, 2024

openjdk bot commented Feb 15, 2024

openjdk bot commented Feb 15, 2024

SoniaZaldana commented Jan 18, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Jan 24, 2024 •

edited

Loading

mlbridge bot commented Jan 24, 2024 •

edited

Loading