Skip to content

8322630: Remove ICStubs and related safepoints #17495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from
Closed

8322630: Remove ICStubs and related safepoints #17495

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
cc98cce
8322630: Remove ICStubs and related safepoints
fisk Nov 15, 2023
82134e6
Remove inaccurate comment
fisk Jan 25, 2024
140a8a1
Whitespace fix
fisk Jan 25, 2024
2ee554e
Platform Comment Cleanup
xmas92 Jan 26, 2024
a8cfe40
Rename register aliases: holder -> data
xmas92 Jan 26, 2024
49758bf
Use relevant global register aliases for clarity
xmas92 Jan 26, 2024
707b271
Suggestion from Axel
fisk Jan 29, 2024
7012996
Axel suggestions
fisk Jan 29, 2024
fc04a60
Cleanup from FYang
fisk Jan 29, 2024
60fa659
JVMCI support
fisk Jan 29, 2024
5487777
Batch allocate and free CompiledICData
fisk Jan 29, 2024
ba5a4dc
Deal with short far branches on AArch64
fisk Jan 30, 2024
42a2198
Add comment
fisk Jan 30, 2024
6dd64b5
ARM32 fixes
fisk Jan 30, 2024
01733b8
Update src/hotspot/share/runtime/sharedRuntime.cpp
fisk Feb 9, 2024
dfdcdcc
Update src/hotspot/share/code/compiledIC.hpp
fisk Feb 9, 2024
08c146b
Feedback from Dean and Thomas
fisk Feb 9, 2024
29790af
Some comments
fisk Feb 12, 2024
2999428
Merge branch 'master' into 8310823_object_streaming
fisk Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/hotspot/cpu/arm/compiledIC_arm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,13 +105,6 @@ void CompiledDirectCall::set_to_interpreted(const methodHandle& callee, address
address stub = find_stub();
guarantee(stub != nullptr, "stub not found");

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other platforms removed the trace logging here. If the ARM porters still want this in at least update to log the correct class name. s/CompiledDirectStaticCall/CompiledDirectCall/

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed by removing the trace logging.

{
ResourceMark rm;
log_trace(inlinecache)("CompiledDirectStaticCall@" INTPTR_FORMAT ": set_to_interpreted %s",
p2i(instruction_address()),
callee->name_and_sig_as_C_string());
}

// Creation also verifies the object.
NativeMovConstReg* method_holder = nativeMovConstReg_at(stub);
NativeJump* jump = nativeJump_at(method_holder->next_instruction_address());
Expand Down
4 changes: 1 addition & 3 deletions src/hotspot/cpu/arm/sharedRuntime_arm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,11 +625,9 @@ AdapterHandlerEntry* SharedRuntime::generate_i2c2i_adapters(MacroAssembler *masm
Label skip_fixup;
const Register receiver = R0;
const Register holder_klass = Rtemp; // XXX should be OK for C2 but not 100% sure
const Register receiver_klass = R4;

__ ic_check(1 /* end_alignment */);
__ ldr(Rmethod, Address(receiver_klass, CompiledICData::speculated_method_offset()));

__ ldr(Rmethod, Address(Ricklass, CompiledICData::speculated_method_offset()));

__ ldr(Rtemp, Address(Rmethod, Method::code_offset()), eq);
__ cmp(Rtemp, 0, eq);
Expand Down