Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253162: Make frame::oops_do const #175

Closed
wants to merge 2 commits into from

Conversation

stefank
Copy link
Member

@stefank stefank commented Sep 15, 2020

Make frame::oops_do const, so that we can use a const frame& receiver when appropriate. With this, we can get rid of the temporary copies made just to make the frame variable non-const. See for example: https://github.com/openjdk/zgc/blob/c4765b5599d07124410f8a80b1acef9349a998e0/src/hotspot/share/gc/z/zStackWatermark.cpp#L96


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/175/head:pull/175
$ git checkout pull/175

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2020

👋 Welcome back stefank! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 15, 2020

@stefank The following label will be automatically applied to this pull request: hotspot.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Sep 15, 2020
@stefank stefank changed the title Make frame::oops_do const 8253162: Make frame::oops_do const Sep 15, 2020
@stefank stefank marked this pull request as ready for review September 15, 2020 11:13
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 15, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 15, 2020

Webrevs

@mlbridge
Copy link

mlbridge bot commented Sep 15, 2020

Mailing list message from Kim Barrett on hotspot-dev:

------------------------------------------------------------------------------
src/hotspot/share/runtime/frame.cpp
1039 void frame::oops_do_internal(OopClosure* f, CodeBlobClosure* cf, RegisterMap* map, bool use_interpreter_oop_map_cache) const {

Why is this register map not const?

------------------------------------------------------------------------------

Looks good other than that.

@openjdk
Copy link

openjdk bot commented Sep 15, 2020

@stefank This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253162: Make frame::oops_do const

Reviewed-by: kbarrett, coleenp, pliden
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 24 commits pushed to the master branch:

  • 300b851: 8253226: Shenandoah: remove unimplemented ShenandoahStrDedupQueue::verify
  • c781594: 8253224: Shenandoah: ShenandoahStrDedupQueue destructor calls virtual num_queues()
  • 33f8e70: 8253173: Print heap before and after GC lacks a newline
  • f509eb0: 8253219: Epsilon: clean up unnecessary includes
  • 7f9b5d9: 8253220: Epsilon: clean up unused code/declarations
  • e0cf023: 8245309: Re-examine use of ThreadLocalCoders in sun.net.www.ParseUtil
  • 60c4902: 8253016: Box.Filler components should be unfocusable by default
  • dd43533: 8253222: Shenandoah: unused AlwaysTrueClosure after JDK-8246591
  • efe3540: 8252966: CI: Remove KILL_COMPILE_ON_FATAL_ and KILL_COMPILE_ON_ANY macros
  • fbf4699: 8253040: Remove unused Matcher::regnum_to_fpu_offset()
  • ... and 14 more: https://git.openjdk.java.net/jdk/compare/fa30241ddbbe953b61526bc3c44784198acdd801...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 300b8517c3d822cda85ff88eee9132169e2689ff.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 15, 2020
Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@stefank
Copy link
Member Author

stefank commented Sep 16, 2020

/integrate

@openjdk openjdk bot closed this Sep 16, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 16, 2020
@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@stefank Since your change was applied there have been 24 commits pushed to the master branch:

  • 300b851: 8253226: Shenandoah: remove unimplemented ShenandoahStrDedupQueue::verify
  • c781594: 8253224: Shenandoah: ShenandoahStrDedupQueue destructor calls virtual num_queues()
  • 33f8e70: 8253173: Print heap before and after GC lacks a newline
  • f509eb0: 8253219: Epsilon: clean up unnecessary includes
  • 7f9b5d9: 8253220: Epsilon: clean up unused code/declarations
  • e0cf023: 8245309: Re-examine use of ThreadLocalCoders in sun.net.www.ParseUtil
  • 60c4902: 8253016: Box.Filler components should be unfocusable by default
  • dd43533: 8253222: Shenandoah: unused AlwaysTrueClosure after JDK-8246591
  • efe3540: 8252966: CI: Remove KILL_COMPILE_ON_FATAL_ and KILL_COMPILE_ON_ANY macros
  • fbf4699: 8253040: Remove unused Matcher::regnum_to_fpu_offset()
  • ... and 14 more: https://git.openjdk.java.net/jdk/compare/fa30241ddbbe953b61526bc3c44784198acdd801...master

Your commit was automatically rebased without conflicts.

Pushed as commit e2196f8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@stefank stefank deleted the 8253162_const_frame_oops_do branch September 28, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
4 participants