8253162: Make frame::oops_do const

[stefank]

Make frame::oops_do const, so that we can use a const frame& receiver when appropriate. With this, we can get rid of the temporary copies made just to make the frame variable non-const. See for example: https://github.com/openjdk/zgc/blob/c4765b5599d07124410f8a80b1acef9349a998e0/src/hotspot/share/gc/z/zStackWatermark.cpp#L96

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8253162: Make frame::oops_do const

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)
• Coleen Phillimore (@coleenp - Reviewer) ⚠️ Review applies to 7d44eec
• Per Lidén (@pliden - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/175/head:pull/175
$ git checkout pull/175

[bridgekeeper]

👋 Welcome back stefank! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@stefank The following label will be automatically applied to this pull request: hotspot.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

[mlbridge]

Webrevs

• 01: Full - Incremental (093bfa9)
• 00: Full (7d44eec)

[mlbridge]

Mailing list message from Kim Barrett on hotspot-dev:

------------------------------------------------------------------------------
src/hotspot/share/runtime/frame.cpp
1039 void frame::oops_do_internal(OopClosure* f, CodeBlobClosure* cf, RegisterMap* map, bool use_interpreter_oop_map_cache) const {

Why is this register map not const?

------------------------------------------------------------------------------

Looks good other than that.

[openjdk]

@stefank This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253162: Make frame::oops_do const

Reviewed-by: kbarrett, coleenp, pliden

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 24 commits pushed to the master branch:

• 300b851: 8253226: Shenandoah: remove unimplemented ShenandoahStrDedupQueue::verify
• c781594: 8253224: Shenandoah: ShenandoahStrDedupQueue destructor calls virtual num_queues()
• 33f8e70: 8253173: Print heap before and after GC lacks a newline
• f509eb0: 8253219: Epsilon: clean up unnecessary includes
• 7f9b5d9: 8253220: Epsilon: clean up unused code/declarations
• e0cf023: 8245309: Re-examine use of ThreadLocalCoders in sun.net.www.ParseUtil
• 60c4902: 8253016: Box.Filler components should be unfocusable by default
• dd43533: 8253222: Shenandoah: unused AlwaysTrueClosure after JDK-8246591
• efe3540: 8252966: CI: Remove KILL_COMPILE_ON_FATAL_ and KILL_COMPILE_ON_ANY macros
• fbf4699: 8253040: Remove unused Matcher::regnum_to_fpu_offset()
• ... and 14 more: https://git.openjdk.java.net/jdk/compare/fa30241ddbbe953b61526bc3c44784198acdd801...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 300b8517c3d822cda85ff88eee9132169e2689ff.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

Looks good to me.

[stefank]

/integrate

[openjdk]

@stefank Since your change was applied there have been 24 commits pushed to the master branch:

• 300b851: 8253226: Shenandoah: remove unimplemented ShenandoahStrDedupQueue::verify
• c781594: 8253224: Shenandoah: ShenandoahStrDedupQueue destructor calls virtual num_queues()
• 33f8e70: 8253173: Print heap before and after GC lacks a newline
• f509eb0: 8253219: Epsilon: clean up unnecessary includes
• 7f9b5d9: 8253220: Epsilon: clean up unused code/declarations
• e0cf023: 8245309: Re-examine use of ThreadLocalCoders in sun.net.www.ParseUtil
• 60c4902: 8253016: Box.Filler components should be unfocusable by default
• dd43533: 8253222: Shenandoah: unused AlwaysTrueClosure after JDK-8246591
• efe3540: 8252966: CI: Remove KILL_COMPILE_ON_FATAL_ and KILL_COMPILE_ON_ANY macros
• fbf4699: 8253040: Remove unused Matcher::regnum_to_fpu_offset()
• ... and 14 more: https://git.openjdk.java.net/jdk/compare/fa30241ddbbe953b61526bc3c44784198acdd801...master

Your commit was automatically rebased without conflicts.

Pushed as commit e2196f8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.