New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8253162: Make frame::oops_do const #175
Conversation
👋 Welcome back stefank! A progress list of the required criteria for merging this PR into |
@stefank The following label will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the |
Webrevs
|
Mailing list message from Kim Barrett on hotspot-dev: ------------------------------------------------------------------------------ Why is this register map not const? ------------------------------------------------------------------------------ Looks good other than that. |
@stefank This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
Since the source branch of this PR was last updated there have been 24 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
/integrate |
@stefank Since your change was applied there have been 24 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit e2196f8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Make frame::oops_do const, so that we can use a const frame& receiver when appropriate. With this, we can get rid of the temporary copies made just to make the frame variable non-const. See for example: https://github.com/openjdk/zgc/blob/c4765b5599d07124410f8a80b1acef9349a998e0/src/hotspot/share/gc/z/zStackWatermark.cpp#L96
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/175/head:pull/175
$ git checkout pull/175