Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8324229: JFR: Temporarily disable assertion for missing object reference #17504

Closed
wants to merge 1 commit into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Jan 19, 2024

Could I have a review of a change that temporarily disables an assertion.

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8324229: JFR: Temporarily disable assertion for missing object reference (Sub-task - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17504/head:pull/17504
$ git checkout pull/17504

Update a local copy of the PR:
$ git checkout pull/17504
$ git pull https://git.openjdk.org/jdk.git pull/17504/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17504

View PR using the GUI difftool:
$ git pr show -t 17504

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17504.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 19, 2024

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 19, 2024

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Jan 19, 2024
@egahlin egahlin marked this pull request as ready for review January 19, 2024 23:19
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 19, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 19, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 20, 2024

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324229: JFR: Temporarily disable assertion for missing object reference

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • f4d08cc: 8318696: Do not use LFS64 symbols on Linux
  • 9049402: 8323675: Race in jdk.javadoc-gendata
  • f1b7335: 8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 20, 2024
@egahlin
Copy link
Member Author

egahlin commented Jan 20, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jan 20, 2024

Going to push as commit 68b5aab.
Since your change was applied there have been 4 commits pushed to the master branch:

  • f54a336: 8324231: bad command-line option in make/Docs.gmk
  • f4d08cc: 8318696: Do not use LFS64 symbols on Linux
  • 9049402: 8323675: Race in jdk.javadoc-gendata
  • f1b7335: 8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 20, 2024
@openjdk openjdk bot closed this Jan 20, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 20, 2024
@openjdk
Copy link

openjdk bot commented Jan 20, 2024

@egahlin Pushed as commit 68b5aab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
2 participants