Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258075: Use auto variable declarations for enum iteration #1751

Closed

Conversation

@iklam
Copy link
Member

@iklam iklam commented Dec 11, 2020

The pattern used in #1707

for (vmIntrinsicID index : EnumRange<vmIntrinsicID>{}) {
  nt[as_int(index)] = string;
}

can be further simplified to the following without loss of readability, since the type of index would obviously be the type enclosed by EnumRange<>

for (auto index : EnumRange<vmIntrinsicID>{}) {
  nt[as_int(index)] = string;
}

(as suggested by John Rose)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258075: Use auto variable declarations for enum iteration

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1751/head:pull/1751
$ git checkout pull/1751

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 11, 2020

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Dec 11, 2020

@iklam The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot label Dec 11, 2020
@iklam iklam marked this pull request as ready for review Dec 11, 2020
@openjdk openjdk bot added the rfr label Dec 11, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 11, 2020

Webrevs

Loading

rose00
rose00 approved these changes Dec 11, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 11, 2020

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258075: Use auto variable declarations for enum iteration

Reviewed-by: jrose, ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 330ce86: 8257700: Add logging for sealed classes in JVM_GetPermittedSubclasses
  • c463264: 8258048: Placeholder hash code is the same as Dictionary hash code
  • ab5d581: 8258447: Move make/hotspot/hotspot.script to make/scripts

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Dec 11, 2020
Copy link
Member

@calvinccheung calvinccheung left a comment

Looks good.

Loading

@iklam
Copy link
Member Author

@iklam iklam commented Dec 16, 2020

Thanks @calvinccheung and @rose00 for the review.
/integrate

Loading

@openjdk openjdk bot closed this Dec 16, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 16, 2020

@iklam Since your change was applied there have been 3 commits pushed to the master branch:

  • 330ce86: 8257700: Add logging for sealed classes in JVM_GetPermittedSubclasses
  • c463264: 8258048: Placeholder hash code is the same as Dictionary hash code
  • ab5d581: 8258447: Move make/hotspot/hotspot.script to make/scripts

Your commit was automatically rebased without conflicts.

Pushed as commit 59f4c4a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants