-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8258075: Use auto variable declarations for enum iteration #1751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back iklam! A progress list of the required criteria for merging this PR into |
Webrevs
|
@iklam This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks @calvinccheung and @rose00 for the review. |
@iklam Since your change was applied there have been 3 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 59f4c4a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The pattern used in #1707
can be further simplified to the following without loss of readability, since the type of
index
would obviously be the type enclosed byEnumRange<>
(as suggested by John Rose)
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1751/head:pull/1751
$ git checkout pull/1751