8217633: Configurable extensions with system properties #1752
@XueleiFan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Yes. The properties will be described in the JSSE Reference Guide. I added a "Documentation" section in the CSR.
Thanks for the review.
I wanted to mention again, that all those System property configurations are good, especially to resolve the update pains, but not really useful if you want to make configurations on a per-connection base. If you have to support multiple partners it can be a real pain to setup a common feature set or multiple instances. For this a generic feature setter for the context would be really useful. Most prominent recent example is the ca-extension, which only really makes sense if you also did programmatically configure a small list of trusted CAs.
I also think it would overall clean up the code and give a good place for Javadoc all those options.
Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision:
Update copyright years to 2021
Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod
I agree with you that System property is not as useful to configure individual connections. It is mostly used for corner cases that have interoperability or compatibility issues. A general program should use APIs and the default system properties.
Yes, ca-extension is an item I was thinking of to support in JDK.
Currently, the system properties are documented in the JSSE Reference Guides. But just as you know, it is as easy to follow. I agree with you that it would be nice to have better place to have them all together.
Thank you for the review.
@XueleiFan This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
At the time when this comment was updated there had been 23 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the
@XueleiFan Since your change was applied there have been 37 commits pushed to the
Your commit was automatically rebased without conflicts.
Pushed as commit 71bfe96.
💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.