Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8307788: vmTestbase/gc/gctests/LargeObjects/large003/TestDescription.java timed out #17524

Closed
wants to merge 2 commits into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Jan 22, 2024

Simple fix to add an explicit timeout to these tests.

See JBS for discussion.

Testing: ran the updated tests through our CI 10x on each platform

Thanks


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8307788: vmTestbase/gc/gctests/LargeObjects/large003/TestDescription.java timed out (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17524/head:pull/17524
$ git checkout pull/17524

Update a local copy of the PR:
$ git checkout pull/17524
$ git pull https://git.openjdk.org/jdk.git pull/17524/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17524

View PR using the GUI difftool:
$ git pr show -t 17524

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17524.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 22, 2024

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 22, 2024
@openjdk
Copy link

openjdk bot commented Jan 22, 2024

@dholmes-ora The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jan 22, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 22, 2024

Webrevs

Copy link
Member

@lmesnik lmesnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good. Might be makes sense to test that this timeout is enough for slowest combination like fastdebug + Xomp and diffferent GCs. But we could check it in CI.
Update: This testing is already done.

@openjdk
Copy link

openjdk bot commented Jan 23, 2024

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307788: vmTestbase/gc/gctests/LargeObjects/large003/TestDescription.java timed out

Reviewed-by: lmesnik, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 3696765: 8323964: runtime/Thread/ThreadCountLimit.java fails intermittently on AIX
  • 5a74c2a: 8323438: Enhance assertions for Windows sync API failures
  • 52523d3: 8324050: Issue store-store barrier after re-materializing objects during deoptimization

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 23, 2024
@dholmes-ora
Copy link
Member Author

Thanks for the reviews @lmesnik and @shipilev .

Might be makes sense to test that this timeout is enough for slowest combination like fastdebug + Xomp and diffferent GCs.

@lmesnik you are right. I only tested this under normal conditions (as it timed out for me under normal conditions locally). I need to run it under higher-tier CI conditions too. Just need to figure out how without running full tiers ...

@dholmes-ora
Copy link
Member Author

Tested under tier 5, 7 and 8 conditions. No timeouts.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 25, 2024

Going to push as commit 929af9e.
Since your change was applied there have been 30 commits pushed to the master branch:

  • e7fdac9: 8324280: RISC-V: Incorrect implementation in VM_Version::parse_satp_mode
  • 3d32c46: 6503196: API doc for DecimalFormat::getMaximumIntegerDigits is unclear
  • 2d5cb97: 8324647: Invalid test group of lib-test after JDK-8323515
  • 6212264: 8320692: Null icon returned for .exe without custom icon
  • 32eb529: 8324553: Shenandoah: Move periodic tasks closer to their collaborators
  • c702dca: 8323815: Source launcher should find classes with $ in names
  • c432dc0: 8322149: ConcurrentHashMap smarter presizing for copy constructor and putAll
  • fb822e4: 8324514: ClassLoaderData::print_on should print address of class loader
  • 00bb6bf: 8324220: jdk/jfr/event/io/TestSerializationMisdeclarationEvent.java had 22 failures
  • bccd823: 8324613: Serial: Rename GenerationPool to TenuredGenerationPool
  • ... and 20 more: https://git.openjdk.org/jdk/compare/df370d725e5ae55a05479e8375bf665233ac3e44...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 25, 2024
@openjdk openjdk bot closed this Jan 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 25, 2024
@openjdk
Copy link

openjdk bot commented Jan 25, 2024

@dholmes-ora Pushed as commit 929af9e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora dholmes-ora deleted the 8307788-largeobject branch January 25, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants