8258134: assert(size == calc_size) failed: incorrect size calculation on x86_32 with AVX512 machines

[DamonFool]

Hi all,

Two vector api tests crashed on x86_32 with AVX512 machines due to this assert [1].
The reason is that 'calc_size' is incorrect.

But there is no need to calculate 'calc_size' manually at all since the result [2] is actually never used by the VM.
Also, it is really hard to maintain the calculation logic for various hardwares and configurations.
And it may be easily broken again in the future with more and more complicated instructions & configurations.

So it would be better to remove the calculation and the assert, which is safe and already done for x86_64 [3].
The fix just follows what is done for x86_64.

Thanks.
Best regards,
Jie

[1] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/x86/x86_32.ad#L1016
[2] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/x86/x86_32.ad#L1059
[3] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/x86/x86_64.ad#L1042

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8258134: assert(size == calc_size) failed: incorrect size calculation on x86_32 with AVX512 machines

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1753/head:pull/1753
$ git checkout pull/1753

[bridgekeeper]

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[DamonFool]

/issue add JDK-8258134
/test
/label add hotspot-compiler
/cc hotspot-compiler

[openjdk]

@DamonFool This issue is referenced in the PR title - it will now be updated.

[openjdk]

@DamonFool
The hotspot-compiler label was successfully added.

[openjdk]

@DamonFool The hotspot-compiler label was already applied.

[mlbridge]

Webrevs

• 00: Full (06d157a)

[neliasso]

None of these functions (vec_stack_to_stack_helper, vec_mov_helper, vec_spill_helper, vec_spill_helper) returns a value that is used on either x86 or x64 now.

Please make them all return void.

[DamonFool]

Thanks @neliasso for your review.
Will do it later.

And I'll close this pr and create a new one into jdk16 since this issue had been targeted to jdk16.

[DamonFool]

The new pr is here: openjdk/jdk16#21
Thanks.