Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout #17535

Closed
wants to merge 1 commit into from

Conversation

DarraghClarke
Copy link
Contributor

@DarraghClarke DarraghClarke commented Jan 23, 2024

Currently HttpURLConnectionExpectContinueTest fails intermittently with a SocketTimeoutException.

The connection timeout that is currently set to 1000 isn't actually needed for the purpose of the test so it should be more stable if the timeout is removed entirely.

I've tested this change for stability it seems reliable.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17535/head:pull/17535
$ git checkout pull/17535

Update a local copy of the PR:
$ git checkout pull/17535
$ git pull https://git.openjdk.org/jdk.git pull/17535/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17535

View PR using the GUI difftool:
$ git pr show -t 17535

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17535.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 23, 2024

👋 Welcome back dclarke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 23, 2024
@openjdk
Copy link

openjdk bot commented Jan 23, 2024

@DarraghClarke The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Jan 23, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 23, 2024

Webrevs

Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the connection timeout seems to be the best route to increase the stability of this test.

@openjdk
Copy link

openjdk bot commented Jan 23, 2024

@DarraghClarke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout

Reviewed-by: dfuchs, djelinski

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 89 new commits pushed to the master branch:

  • 791b427: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
  • bcaad51: 8318228: RISC-V: C2 ConvF2HF
  • 5acd37f: 8324207: Serial: Remove Space::set_saved_mark_word
  • f5e6d11: 8324210: Serial: Remove unused methods in Generation
  • bcb340d: 8324286: Fix backsliding on use of nullptr instead of NULL
  • 3696765: 8323964: runtime/Thread/ThreadCountLimit.java fails intermittently on AIX
  • 5a74c2a: 8323438: Enhance assertions for Windows sync API failures
  • 52523d3: 8324050: Issue store-store barrier after re-materializing objects during deoptimization
  • df370d7: 8314329: AgeTable: add is_clear() & allocation spec, and relax assert to allow use of 0-index slot
  • 0d8543d: 8324065: Daylight saving information for Africa/Casablanca are incorrect
  • ... and 79 more: https://git.openjdk.org/jdk/compare/59062402b9c5ed5612a13c1c40eb22cf1b97c41a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 23, 2024
@DarraghClarke
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 23, 2024

Going to push as commit fbaaac6.
Since your change was applied there have been 89 commits pushed to the master branch:

  • 791b427: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
  • bcaad51: 8318228: RISC-V: C2 ConvF2HF
  • 5acd37f: 8324207: Serial: Remove Space::set_saved_mark_word
  • f5e6d11: 8324210: Serial: Remove unused methods in Generation
  • bcb340d: 8324286: Fix backsliding on use of nullptr instead of NULL
  • 3696765: 8323964: runtime/Thread/ThreadCountLimit.java fails intermittently on AIX
  • 5a74c2a: 8323438: Enhance assertions for Windows sync API failures
  • 52523d3: 8324050: Issue store-store barrier after re-materializing objects during deoptimization
  • df370d7: 8314329: AgeTable: add is_clear() & allocation spec, and relax assert to allow use of 0-index slot
  • 0d8543d: 8324065: Daylight saving information for Africa/Casablanca are incorrect
  • ... and 79 more: https://git.openjdk.org/jdk/compare/59062402b9c5ed5612a13c1c40eb22cf1b97c41a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 23, 2024
@openjdk openjdk bot closed this Jan 23, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 23, 2024
@openjdk
Copy link

openjdk bot commented Jan 23, 2024

@DarraghClarke Pushed as commit fbaaac6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
3 participants