8223696: java/net/httpclient/MaxStreams.java failed with didn't finish within the time-out

[djelinski]

The test was occasionally failing with TestNG timeout. When a TestNG test times out, TestNG interrupts the test thread, and starts another test case in a new thread. The timeout is invisible to JTReg, and the timeout failure handlers are not run.

This PR removes the TestNG timeout. It also removes -ea -esa from the test command line (the test does not use assert), and reduces the amount of synchronization objects used.

I verified that the timeouts are now handled by JTReg. The test still passes.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8223696: java/net/httpclient/MaxStreams.java failed with didn't finish within the time-out (Bug - P4)

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17536/head:pull/17536
$ git checkout pull/17536

Update a local copy of the PR:
$ git checkout pull/17536
$ git pull https://git.openjdk.org/jdk.git pull/17536/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17536

View PR using the GUI difftool:
$ git pr show -t 17536

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17536.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@djelinski The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (ef74f79d)
• 00: Full (55db7ea8)

[dfuch]

Can we keep/add a trace here to say that counter is reset to 0?
Otherwise looks good.

[djelinski]

Log added.

[openjdk]

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8223696: java/net/httpclient/MaxStreams.java failed with didn't finish within the time-out

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• 6d2f640: 8324578: [BACKOUT] [IMPROVE] OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE
• c17059d: 8324334: Shenandoah: Improve end of process report
• 96607df: 8321545: Override toString() for Format subclasses
• edfee7f: 8323546: Cleanup jcmd docs for Compiler.perfmap and VM.cds filename parameter
• 8b9bf75: 8323515: Create test alias "all" for all test roots
• 3d82363: 8300088: [IMPROVE] OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE
• 2a01c79: 8324513: Inline ContiguousSpace::object_iterate_from
• fbaaac6: 8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout
• 791b427: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
• bcaad51: 8318228: RISC-V: C2 ConvF2HF
• ... and 8 more: https://git.openjdk.org/jdk/compare/c9cacfb25d1f15c879c961d2965a63c9fe4d9fa7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[djelinski]

/integrate

[openjdk]

Going to push as commit 95310ea.
Since your change was applied there have been 42 commits pushed to the master branch:

• 39b756a: 8324492: Remove Atomic support for OopHandle
• 12b89cd: 8323717: Introduce test keyword for tests that need external dependencies
• 746a086: 8306767: Concurrent repacking of extra data in MethodData is potentially unsafe
• ffe3bb6: 8324657: Intermittent OOME on exception message create
• e709842: 8324636: Serial: Remove Generation::block_is_obj
• 7a798d3: 8324598: use mem_unit when working with sysinfo memory and swap related information
• 6d36eb7: 8322768: Optimize non-subword vector compress and expand APIs for AVX2 target.
• 9d1a6d1: 8323645: Remove unused internal sun.net.www.protocol.jar.URLJarFileCallBack interface
• 3059c3b: 8324242: Avoid null check for OopHandle::ptr_raw()
• 929af9e: 8307788: vmTestbase/gc/gctests/LargeObjects/large003/TestDescription.java timed out
• ... and 32 more: https://git.openjdk.org/jdk/compare/c9cacfb25d1f15c879c961d2965a63c9fe4d9fa7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@djelinski Pushed as commit 95310ea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.