Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257457: Update --release 16 symbol information for JDK 16 build 28 #1754

Closed
wants to merge 1 commit into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Dec 12, 2020

Update symbol information for --release 16 to JDK 16 b28, includes updates for JEP 390.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257457: Update --release 16 symbol information for JDK 16 build 28

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1754/head:pull/1754
$ git checkout pull/1754

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2020

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 12, 2020
@openjdk
Copy link

openjdk bot commented Dec 12, 2020

@jddarcy The following labels will be automatically applied to this pull request:

  • build
  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build compiler labels Dec 12, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 12, 2020

Webrevs

@magicus
Copy link
Member

magicus commented Dec 15, 2020

/label remove build

@openjdk openjdk bot removed the build label Dec 15, 2020
@openjdk
Copy link

openjdk bot commented Dec 15, 2020

@magicus
The build label was successfully removed.

Copy link
Contributor

@jonathan-gibbons jonathan-gibbons left a comment

Looks reasonable

@openjdk
Copy link

openjdk bot commented Dec 15, 2020

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257457: Update --release 16 symbol information for JDK 16 build 28

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

  • 36e2097: 8255917: runtime/cds/SharedBaseAddress.java failed "assert(reserved_rgn != 0LL) failed: No reserved region"
  • d53ee62: 8255899: Allow uninstallation of jpackage exe bundles
  • 65756ab: 8257802: LogCompilation throws couldn't find bytecode on JDK 8 log
  • a372be4: 8258244: Shenandoah: Not expecting forwarded object in roots during mark after JDK-8240868
  • 568dc29: 8185734: [Windows] Structured Exception Catcher missing around gtest execution
  • 3ab1dfe: 8257828: SafeFetch may crash if invoked in non-JavaThreads
  • 381021a: Merge
  • afc4441: 8258094: AIX build fails after 8257602
  • 164c8a6: 8258092: Link to early access platform documentation in TestHtmlTableTags.java
  • 43dc3f7: 8254350: CompletableFuture.get may swallow InterruptedException
  • ... and 17 more: https://git.openjdk.java.net/jdk/compare/74b79c6e191d8c39da7be37d9c01ccbbbd103857...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 15, 2020
@jddarcy
Copy link
Member Author

jddarcy commented Dec 15, 2020

/integrate

@openjdk openjdk bot closed this Dec 15, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 15, 2020
@openjdk
Copy link

openjdk bot commented Dec 15, 2020

@jddarcy Since your change was applied there have been 27 commits pushed to the master branch:

  • 36e2097: 8255917: runtime/cds/SharedBaseAddress.java failed "assert(reserved_rgn != 0LL) failed: No reserved region"
  • d53ee62: 8255899: Allow uninstallation of jpackage exe bundles
  • 65756ab: 8257802: LogCompilation throws couldn't find bytecode on JDK 8 log
  • a372be4: 8258244: Shenandoah: Not expecting forwarded object in roots during mark after JDK-8240868
  • 568dc29: 8185734: [Windows] Structured Exception Catcher missing around gtest execution
  • 3ab1dfe: 8257828: SafeFetch may crash if invoked in non-JavaThreads
  • 381021a: Merge
  • afc4441: 8258094: AIX build fails after 8257602
  • 164c8a6: 8258092: Link to early access platform documentation in TestHtmlTableTags.java
  • 43dc3f7: 8254350: CompletableFuture.get may swallow InterruptedException
  • ... and 17 more: https://git.openjdk.java.net/jdk/compare/74b79c6e191d8c39da7be37d9c01ccbbbd103857...master

Your commit was automatically rebased without conflicts.

Pushed as commit da2415f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy jddarcy deleted the 8257457 branch Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler integrated
3 participants