8324553: Shenandoah: Move periodic tasks closer to their collaborators

[earthling-amzn]

This is a refactoring to move Shenandoah's periodic tasks from the control thread to their respective dependencies: the pacer and monitoring support. This change will facilitate reviews of the upcoming changes to isolate the generational mode changes.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8324553: Shenandoah: Move periodic tasks closer to their collaborators (Task - P4)

Reviewers

• Kelvin Nilsen (@kdnilsen - no project role) ⚠️ Review applies to 635633bb
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17540/head:pull/17540
$ git checkout pull/17540

Update a local copy of the PR:
$ git checkout pull/17540
$ git pull https://git.openjdk.org/jdk.git pull/17540/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17540

View PR using the GUI difftool:
$ git pr show -t 17540

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17540.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@earthling-amzn The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (09eeaa4c)
• 00: Full (635633bb)

[shipilev]

I need to look at it with fresh eyes tomorrow, but a couple of stylistic comments now:

[shipilev]

Looks fine.

[openjdk]

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324553: Shenandoah: Move periodic tasks closer to their collaborators

Reviewed-by: kdnilsen, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

• fb822e4: 8324514: ClassLoaderData::print_on should print address of class loader
• 00bb6bf: 8324220: jdk/jfr/event/io/TestSerializationMisdeclarationEvent.java had 22 failures
• bccd823: 8324613: Serial: Rename GenerationPool to TenuredGenerationPool
• 8c003d8: 8321512: runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java fails on 32-bit platforms
• 67f29b1: 8324537: Remove superfluous _FILE_OFFSET_BITS=64
• 1c1cb04: 8324512: Serial: Remove Generation::Name
• b65e5eb: 8324543: Remove Space::object_iterate
• 6d2f640: 8324578: [BACKOUT] [IMPROVE] OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE
• c17059d: 8324334: Shenandoah: Improve end of process report
• 96607df: 8321545: Override toString() for Format subclasses
• ... and 13 more: https://git.openjdk.org/jdk/compare/df370d725e5ae55a05479e8375bf665233ac3e44...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[earthling-amzn]

/integrate

[openjdk]

@earthling-amzn
Your change (at version 09eeaa4) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 32eb529.
Since your change was applied there have been 25 commits pushed to the master branch:

• c702dca: 8323815: Source launcher should find classes with $ in names
• c432dc0: 8322149: ConcurrentHashMap smarter presizing for copy constructor and putAll
• fb822e4: 8324514: ClassLoaderData::print_on should print address of class loader
• 00bb6bf: 8324220: jdk/jfr/event/io/TestSerializationMisdeclarationEvent.java had 22 failures
• bccd823: 8324613: Serial: Rename GenerationPool to TenuredGenerationPool
• 8c003d8: 8321512: runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java fails on 32-bit platforms
• 67f29b1: 8324537: Remove superfluous _FILE_OFFSET_BITS=64
• 1c1cb04: 8324512: Serial: Remove Generation::Name
• b65e5eb: 8324543: Remove Space::object_iterate
• 6d2f640: 8324578: [BACKOUT] [IMPROVE] OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE
• ... and 15 more: https://git.openjdk.org/jdk/compare/df370d725e5ae55a05479e8375bf665233ac3e44...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @earthling-amzn Pushed as commit 32eb529.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.