Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8324125: Improve class initialization barrier in TemplateTable::_new for RISC-V #17548

Closed
wants to merge 2 commits into from

Conversation

zifeihan
Copy link
Member

@zifeihan zifeihan commented Jan 24, 2024

Hi, This RISC-V Port implementation for #17006,

Testing:

  • Run tier1-3 tests on qemu 8.1.0 with UseRVV (fastdebug)
  • Run tier1-3 tests with SiFive unmatched (release)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8324125: Improve class initialization barrier in TemplateTable::_new for RISC-V (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17548/head:pull/17548
$ git checkout pull/17548

Update a local copy of the PR:
$ git checkout pull/17548
$ git pull https://git.openjdk.org/jdk.git pull/17548/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17548

View PR using the GUI difftool:
$ git pr show -t 17548

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17548.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 24, 2024

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 24, 2024

@zifeihan The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jan 24, 2024
@zifeihan zifeihan marked this pull request as ready for review January 25, 2024 07:48
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 25, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 25, 2024

Webrevs

src/hotspot/cpu/riscv/templateTable_riscv.cpp Outdated Show resolved Hide resolved
@openjdk
Copy link

openjdk bot commented Jan 25, 2024

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324125: Improve class initialization barrier in TemplateTable::_new for RISC-V

Reviewed-by: fyang, rehn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 79 new commits pushed to the master branch:

  • b6d364a: 8324865: windows-x64-slowdebug still does not build after JDK-8324840
  • 64c3642: 8242564: javadoc crashes:: class cast exception com.sun.tools.javac.code.Symtab$6
  • e999dfc: 8323503: x86: Shorter movptr(reg, imm) for 32-bit unsigned immediates
  • 84deeb6: 8324667: fold Parse::seems_stable_comparison()
  • fb07bbe: 8324717: Remove HotSpotJVMCICompilerFactory
  • d1e6763: 8324733: [macos14] Problem list tests which fail due to macOS bug described in JDK-8322653
  • c1281e6: 8324678: Replace NULL with nullptr in HotSpot gtests
  • a6bdee4: 8324681: Replace NULL with nullptr in HotSpot jtreg test native code files
  • 951b5f8: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16
  • fe0eec7: 8324840: windows-x64-slowdebug does not build anymore after JDK-8317572
  • ... and 69 more: https://git.openjdk.org/jdk/compare/5a74c2a67ebcb47e51732f03c4be694bdf920469...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang, @robehn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 25, 2024
Copy link
Contributor

@robehn robehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zifeihan
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 30, 2024
@openjdk
Copy link

openjdk bot commented Jan 30, 2024

@zifeihan
Your change (at version 0935a0b) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 30, 2024

Going to push as commit a1d65eb.
Since your change was applied there have been 79 commits pushed to the master branch:

  • b6d364a: 8324865: windows-x64-slowdebug still does not build after JDK-8324840
  • 64c3642: 8242564: javadoc crashes:: class cast exception com.sun.tools.javac.code.Symtab$6
  • e999dfc: 8323503: x86: Shorter movptr(reg, imm) for 32-bit unsigned immediates
  • 84deeb6: 8324667: fold Parse::seems_stable_comparison()
  • fb07bbe: 8324717: Remove HotSpotJVMCICompilerFactory
  • d1e6763: 8324733: [macos14] Problem list tests which fail due to macOS bug described in JDK-8322653
  • c1281e6: 8324678: Replace NULL with nullptr in HotSpot gtests
  • a6bdee4: 8324681: Replace NULL with nullptr in HotSpot jtreg test native code files
  • 951b5f8: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16
  • fe0eec7: 8324840: windows-x64-slowdebug does not build anymore after JDK-8317572
  • ... and 69 more: https://git.openjdk.org/jdk/compare/5a74c2a67ebcb47e51732f03c4be694bdf920469...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 30, 2024
@openjdk openjdk bot closed this Jan 30, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 30, 2024
@openjdk
Copy link

openjdk bot commented Jan 30, 2024

@RealFYang @zifeihan Pushed as commit a1d65eb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@zifeihan zifeihan deleted the JDK-8324125 branch January 30, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants