8324636: Serial: Remove Generation::block_is_obj

[albertnetymk]

Trivial moving a method from Generation to subclass.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8324636: Serial: Remove Generation::block_is_obj (Enhancement - P4)

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Y. Srinivas Ramakrishna (@ysramakrishna - Reviewer) ⚠️ Review applies to 4f655ef8

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17555/head:pull/17555
$ git checkout pull/17555

Update a local copy of the PR:
$ git checkout pull/17555
$ git pull https://git.openjdk.org/jdk.git pull/17555/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17555

View PR using the GUI difftool:
$ git pr show -t 17555

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17555.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (8eb6ea6b)
• 00: Full (4f655ef8)

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324636: Serial: Remove Generation::block_is_obj

Reviewed-by: stefank, ysr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 7a798d3: 8324598: use mem_unit when working with sysinfo memory and swap related information
• 6d36eb7: 8322768: Optimize non-subword vector compress and expand APIs for AVX2 target.
• 9d1a6d1: 8323645: Remove unused internal sun.net.www.protocol.jar.URLJarFileCallBack interface
• 3059c3b: 8324242: Avoid null check for OopHandle::ptr_raw()
• 929af9e: 8307788: vmTestbase/gc/gctests/LargeObjects/large003/TestDescription.java timed out
• e7fdac9: 8324280: RISC-V: Incorrect implementation in VM_Version::parse_satp_mode
• 3d32c46: 6503196: API doc for DecimalFormat::getMaximumIntegerDigits is unclear
• 2d5cb97: 8324647: Invalid test group of lib-test after JDK-8323515
• 6212264: 8320692: Null icon returned for .exe without custom icon
• 32eb529: 8324553: Shenandoah: Move periodic tasks closer to their collaborators
• ... and 4 more: https://git.openjdk.org/jdk/compare/bccd823c8e40863bed70ff5b24772843203871a5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[ysramakrishna]

Please ensure that the header file documentation isn't lost because of this change. Looks fine otherwise.

[albertnetymk]

Please ensure that the header file documentation isn't lost because of this change.

The doc is in SerialHeap::block_is_obj, the actual public API.

[ysramakrishna]

Please ensure that the header file documentation isn't lost because of this change.

The doc is in SerialHeap::block_is_obj, the actual public API.

It would be good to have documentation in the header file of the highest supertype that exposes the API, rather than having to look at the callers of that API and their API documentation to impute that information. That said, I'll leave it up to you to decide if that is sufficiently persuasive to replicate the documentation and make it more maintainable.

Reviewed!

[stefank]

I agree with @ysramakrishna that it would be good to retain the documentation. These name are somewhat obscure, and without prior knowledge it is hard go guess what the contract is.

[albertnetymk]

Moved the doc to the method in subclasses.

[albertnetymk]

Thanks for review.

/integrate

[openjdk]

Going to push as commit e709842.
Since your change was applied there have been 14 commits pushed to the master branch:

• 7a798d3: 8324598: use mem_unit when working with sysinfo memory and swap related information
• 6d36eb7: 8322768: Optimize non-subword vector compress and expand APIs for AVX2 target.
• 9d1a6d1: 8323645: Remove unused internal sun.net.www.protocol.jar.URLJarFileCallBack interface
• 3059c3b: 8324242: Avoid null check for OopHandle::ptr_raw()
• 929af9e: 8307788: vmTestbase/gc/gctests/LargeObjects/large003/TestDescription.java timed out
• e7fdac9: 8324280: RISC-V: Incorrect implementation in VM_Version::parse_satp_mode
• 3d32c46: 6503196: API doc for DecimalFormat::getMaximumIntegerDigits is unclear
• 2d5cb97: 8324647: Invalid test group of lib-test after JDK-8323515
• 6212264: 8320692: Null icon returned for .exe without custom icon
• 32eb529: 8324553: Shenandoah: Move periodic tasks closer to their collaborators
• ... and 4 more: https://git.openjdk.org/jdk/compare/bccd823c8e40863bed70ff5b24772843203871a5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit e709842.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.