Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8324647: Invalid test group of lib-test after JDK-8323515 #17558

Closed
wants to merge 1 commit into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Jan 24, 2024

This patch tries to fix the invalid test group definition of lib-test.
Please review.
Thanks.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8324647: Invalid test group of lib-test after JDK-8323515 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17558/head:pull/17558
$ git checkout pull/17558

Update a local copy of the PR:
$ git checkout pull/17558
$ git pull https://git.openjdk.org/jdk.git pull/17558/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17558

View PR using the GUI difftool:
$ git pr show -t 17558

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17558.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 24, 2024

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 24, 2024
@openjdk
Copy link

openjdk bot commented Jan 24, 2024

@DamonFool The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 24, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 24, 2024

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooof. I wonder how that happened. This would not show up before we try to run the actual libtest tests. What is extra wild is that GHA reports green, even though the logs say that TEST.groups is incorrect! I am going to go and fix that...

The fix looks good and trivial. Thanks for catching it!

@openjdk
Copy link

openjdk bot commented Jan 24, 2024

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324647: Invalid test group of lib-test after JDK-8323515

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 00bb6bf: 8324220: jdk/jfr/event/io/TestSerializationMisdeclarationEvent.java had 22 failures

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 24, 2024
@DamonFool
Copy link
Member Author

Thanks @shipilev .
/integrate

@openjdk
Copy link

openjdk bot commented Jan 24, 2024

Going to push as commit 2d5cb97.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 6212264: 8320692: Null icon returned for .exe without custom icon
  • 32eb529: 8324553: Shenandoah: Move periodic tasks closer to their collaborators
  • c702dca: 8323815: Source launcher should find classes with $ in names
  • c432dc0: 8322149: ConcurrentHashMap smarter presizing for copy constructor and putAll
  • fb822e4: 8324514: ClassLoaderData::print_on should print address of class loader
  • 00bb6bf: 8324220: jdk/jfr/event/io/TestSerializationMisdeclarationEvent.java had 22 failures

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 24, 2024
@openjdk openjdk bot closed this Jan 24, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 24, 2024
@openjdk
Copy link

openjdk bot commented Jan 24, 2024

@DamonFool Pushed as commit 2d5cb97.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonFool DamonFool deleted the JDK-8324647 branch January 24, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants