8324717: Remove HotSpotJVMCICompilerFactory

[dougxc]

There has been no active use of jdk.vm.ci.hotspot.HotSpotJVMCICompilerFactory.CompilationLevelAdjustment since JDK-8219403 effectively disabled it. Since HotSpotJVMCICompilerFactory exists solely for CompilationLevelAdjustment related logic, this PR removes the whole HotSpotJVMCICompilerFactory class.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8324717: Remove HotSpotJVMCICompilerFactory (Enhancement - P4)

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)
• Tom Rodriguez (@tkrodriguez - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17570/head:pull/17570
$ git checkout pull/17570

Update a local copy of the PR:
$ git checkout pull/17570
$ git pull https://git.openjdk.org/jdk.git pull/17570/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17570

View PR using the GUI difftool:
$ git pr show -t 17570

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17570.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dougxc The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[dougxc]

Graal PR to adopt this change: oracle/graal#8252

[mlbridge]

Webrevs

• 00: Full (5685d9ca)

[TobiHartmann]

Looks good to me.

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324717: Remove HotSpotJVMCICompilerFactory

Reviewed-by: thartmann, never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

• c1281e6: 8324678: Replace NULL with nullptr in HotSpot gtests
• a6bdee4: 8324681: Replace NULL with nullptr in HotSpot jtreg test native code files
• 951b5f8: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16
• fe0eec7: 8324840: windows-x64-slowdebug does not build anymore after JDK-8317572
• 4df04f0: 8324769: Serial: Remove unused TenuredGeneration::unsafe_max_alloc_nogc
• 3066d49: 8317572: C2 SuperWord: refactor/improve TraceSuperWord, replace VectorizeDebugOption with TraceAutoVectorization
• 7a300b6: 8324213: C1: There is no need for Canonicalizer to handle IfOp
• 628348d: 8324186: Use "dmb.ishst+dmb.ishld" for release barrier
• 72ba817: 8324236: compiler/ciReplay/TestInliningProtectionDomain.java failed with RuntimeException: should only dump inline information for ... expected true, was false
• b39b876: 8324304: RISC-V: add hw probe flags
• ... and 31 more: https://git.openjdk.org/jdk/compare/6d36eb78ad781ecd80d66d1319921a8746820394...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dougxc]

Thanks for the reviews.

/integrate

[openjdk]

Going to push as commit fb07bbe.
Since your change was applied there have been 42 commits pushed to the master branch:

• d1e6763: 8324733: [macos14] Problem list tests which fail due to macOS bug described in JDK-8322653
• c1281e6: 8324678: Replace NULL with nullptr in HotSpot gtests
• a6bdee4: 8324681: Replace NULL with nullptr in HotSpot jtreg test native code files
• 951b5f8: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16
• fe0eec7: 8324840: windows-x64-slowdebug does not build anymore after JDK-8317572
• 4df04f0: 8324769: Serial: Remove unused TenuredGeneration::unsafe_max_alloc_nogc
• 3066d49: 8317572: C2 SuperWord: refactor/improve TraceSuperWord, replace VectorizeDebugOption with TraceAutoVectorization
• 7a300b6: 8324213: C1: There is no need for Canonicalizer to handle IfOp
• 628348d: 8324186: Use "dmb.ishst+dmb.ishld" for release barrier
• 72ba817: 8324236: compiler/ciReplay/TestInliningProtectionDomain.java failed with RuntimeException: should only dump inline information for ... expected true, was false
• ... and 32 more: https://git.openjdk.org/jdk/compare/6d36eb78ad781ecd80d66d1319921a8746820394...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit fb07bbe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.