JDK-8317636: Improve heap walking API tests to verify correctness of field indexes

[alexmenkov]

The fix adds new test for FollowReferences JVMTI function to verify correctness of reported field indexes.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8317636: Improve heap walking API tests to verify correctness of field indexes (Enhancement - P4)

Reviewers

• Chris Plummer (@plummercj - Reviewer) ⚠️ Review applies to c5e7b787
• Serguei Spitsyn (@sspitsyn - Reviewer) ⚠️ Review applies to a0fffef3

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17580/head:pull/17580
$ git checkout pull/17580

Update a local copy of the PR:
$ git checkout pull/17580
$ git pull https://git.openjdk.org/jdk.git pull/17580/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17580

View PR using the GUI difftool:
$ git pr show -t 17580

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17580.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexmenkov The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (42e79303)
• 02: Full - Incremental (a0fffef3)
• 01: Full - Incremental (c5e7b787)
• 00: Full (6276448d)

[openjdk]

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317636: Improve heap walking API tests to verify correctness of field indexes

Reviewed-by: cjplummer, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 104 new commits pushed to the master branch:

• a18b03b: 8324635: (zipfs) Regression in Files.setPosixFilePermissions called on existing MSDOS entries
• 7476e29: 8323680: SA PointerFinder code can do a better job of leveraging existing code to determine if an address is in the TLAB
• 63cb1f8: 8321396: Retire test/jdk/java/util/zip/NoExtensionSignature.java
• f613e13: 8313739: ZipOutputStream.close() should always close the wrapped stream
• adc3604: 8325148: Enable restricted javac warning in java.base
• 1ae8513: 8324858: [vectorapi] Bounds checking issues when accessing memory segments
• 38c0197: 8318105: [jmh] the test java.security.HSS failed with 2 active threads
• 6787c4c: 8325055: Rename Injector.h
• 91d8dac: 8325137: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java can fail in Xcomp with out of expected range
• 783ae56: 8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name
• ... and 94 more: https://git.openjdk.org/jdk/compare/3d32c460eb60aa95f27c96bbefdf784f6a7663f7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sspitsyn]

Nice test, thank you for developing it!
Looks good.

[alexmenkov]

/integrate

[openjdk]

Going to push as commit f31957e.
Since your change was applied there have been 125 commits pushed to the master branch:

• fd3042a: 8318566: Heap walking functions should not use FilteredFieldStream
• 209d87a: 8324960: Unsafe.allocateMemory documentation incorrect regarding zero return value
• 7777eb5: 8321931: memory_swap_current_in_bytes reports 0 as "unlimited"
• 51853f7: 8324724: Add Stub routines for FP16 conversions on aarch64
• c3adc61: 8325199: (zipfs) jdk/nio/zipfs/TestPosix.java failed 6 sub-tests
• 1993652: 8324983: race in CompileBroker::possibly_add_compiler_threads
• 55c1446: 8321468: Remove StringUTF16::equals
• 19e9220: 8325169: Reduce String::indexOf overheads
• 89e6a02: 8325064: C2 SuperWord: refactor construct_bb
• d395ac2: 8321373: Build should use LC_ALL=C.UTF-8
• ... and 115 more: https://git.openjdk.org/jdk/compare/3d32c460eb60aa95f27c96bbefdf784f6a7663f7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexmenkov Pushed as commit f31957e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.