Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8324750: C2: rename Matcher methods using "superword" -> "autovectorization" #17583

Closed
wants to merge 2 commits into from
Closed

8324750: C2: rename Matcher methods using "superword" -> "autovectorization" #17583

wants to merge 2 commits into from

Conversation

eme64
Copy link
Contributor

@eme64 eme64 commented Jan 26, 2024 •
edited by openjdk bot
Loading

Subtask of #16620

Matcher::superword_max_vector_size -> Matcher::max_vector_size_autovectorization

Matcher::match_rule_supported_superword -> match_rule_supported_autovectorization

This is to make the naming more general, since these methods can be used by any autovectorizer in the future.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8324750: C2: rename Matcher methods using "superword" -> "autovectorization" (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17583/head:pull/17583
$ git checkout pull/17583

Update a local copy of the PR:
$ git checkout pull/17583
$ git pull https://git.openjdk.org/jdk.git pull/17583/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17583

View PR using the GUI difftool:
$ git pr show -t 17583

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17583.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 26, 2024

👋 Welcome back epeter! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@eme64 eme64 marked this pull request as ready for review January 26, 2024 09:56
@openjdk openjdk bot changed the title 8324750 8324750: C2: rename Matcher methods using "superword" -> "autovectorization" Jan 26, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 26, 2024
@openjdk
Copy link

openjdk bot commented Jan 26, 2024

@eme64 The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jan 26, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 26, 2024 •
edited
Loading

Webrevs

vnkozlov
vnkozlov approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and I think trivial.

@openjdk
Copy link

openjdk bot commented Jan 26, 2024 •
edited
Loading

@eme64 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324750: C2: rename Matcher methods using "superword" -> "autovectorization"

Reviewed-by: kvn, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 26, 2024
chhagedorn
chhagedorn reviewed Jan 26, 2024
View reviewed changes
src/hotspot/cpu/aarch64/aarch64.ad Outdated
@@ -2377,7 +2377,7 @@ int Matcher::min_vector_size(const BasicType bt) {
return MIN2(size, max_size);
}

int Matcher::superword_max_vector_size(const BasicType bt) {
int Matcher::max_vector_size_autovectorization(const BasicType bt) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use two separate words like auto_vectorization?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

vnkozlov
vnkozlov approved these changes Jan 27, 2024
View reviewed changes
Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update is good.

chhagedorn
chhagedorn approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, looks good!

@eme64
Copy link
Contributor Author

eme64 commented Jan 29, 2024

Thanks for the reviews @chhagedorn @vnkozlov !
/integrate

@openjdk
Copy link

openjdk bot commented Jan 29, 2024

Going to push as commit f0bae79.
Since your change was applied there have been 17 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 29, 2024
@openjdk openjdk bot closed this Jan 29, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 29, 2024
@openjdk
Copy link

openjdk bot commented Jan 29, 2024

@eme64 Pushed as commit f0bae79.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chhagedorn chhagedorn chhagedorn approved these changes

@vnkozlov vnkozlov vnkozlov approved these changes

Assignees
No one assigned
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eme64 @vnkozlov @chhagedorn