-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8324753: [AIX] adjust os_posix after JDK-8318696 #17587
Conversation
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and should revert the change of JDK-831696 for AIX.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Hi Joachim and Thomas, thanks for the reviews ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Sorry for missing that the earlier change would affect AIX.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also apologies for forgetting about AIX in the original change.
Thanks for the reviews ! /integrate |
Going to push as commit 8950d68.
Your commit was automatically rebased without conflicts. |
JDK-8318696 changed not only Linux related os coding, but also os_posix.
Unfortunately, this touches AIX as well, we use there now the non-large-file functions (e.g. lseek) which could be problematic.
See also https://www.ibm.com/docs/en/aix/7.1?topic=volumes-writing-programs-that-access-large-files .
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17587/head:pull/17587
$ git checkout pull/17587
Update a local copy of the PR:
$ git checkout pull/17587
$ git pull https://git.openjdk.org/jdk.git pull/17587/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 17587
View PR using the GUI difftool:
$ git pr show -t 17587
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17587.diff
Webrev
Link to Webrev Comment