Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8324753: [AIX] adjust os_posix after JDK-8318696 #17587

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jan 26, 2024

JDK-8318696 changed not only Linux related os coding, but also os_posix.
Unfortunately, this touches AIX as well, we use there now the non-large-file functions (e.g. lseek) which could be problematic.
See also https://www.ibm.com/docs/en/aix/7.1?topic=volumes-writing-programs-that-access-large-files .


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8324753: [AIX] adjust os_posix after JDK-8318696 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17587/head:pull/17587
$ git checkout pull/17587

Update a local copy of the PR:
$ git checkout pull/17587
$ git pull https://git.openjdk.org/jdk.git pull/17587/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17587

View PR using the GUI difftool:
$ git pr show -t 17587

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17587.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 26, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 26, 2024
@openjdk
Copy link

openjdk bot commented Jan 26, 2024

@MBaesken The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jan 26, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 26, 2024

Webrevs

Copy link
Contributor

@JoKern65 JoKern65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and should revert the change of JDK-831696 for AIX.

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@openjdk
Copy link

openjdk bot commented Jan 26, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324753: [AIX] adjust os_posix after JDK-8318696

Reviewed-by: jkern, stuefe, kbarrett, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 2e748c9: 8175386: Clarify exception behavior of Types utility methods
  • 70f4a4e: 8324786: validate-source fails after JDK-8042981
  • ed3272c: 8042981: Strip type annotations in Types' utility methods
  • 6d18562: 8324785: ProblemList two tests on linux due to JDK-8315923
  • 91d8ea7: 8323835: Updating ASM to 9.6 for JDK 23
  • a65a895: 8315923: pretouch_memory by atomic-add-0 fragments huge pages unexpectedly
  • 62b3293: 8324241: Always record evol_method deps to avoid excessive method flushing
  • 885e9b7: 8324722: Serial: Inline block_is_obj of subclasses of Generation
  • 32ddcf5: 8324301: Obsolete MaxGCMinorPauseMillis

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 26, 2024
@MBaesken
Copy link
Member Author

Hi Joachim and Thomas, thanks for the reviews !

Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Sorry for missing that the earlier change would affect AIX.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also apologies for forgetting about AIX in the original change.

@MBaesken
Copy link
Member Author

Thanks for the reviews !

/integrate

@openjdk
Copy link

openjdk bot commented Jan 29, 2024

Going to push as commit 8950d68.
Since your change was applied there have been 11 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 29, 2024
@openjdk openjdk bot closed this Jan 29, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 29, 2024
@openjdk
Copy link

openjdk bot commented Jan 29, 2024

@MBaesken Pushed as commit 8950d68.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
5 participants