8324765: C2 SuperWord: remove dead code: SuperWord::insert_extracts

[eme64]

Subtask of #16620

As far as all tests and code study have showed me, SuperWord::insert_extracts is dead.

I am replacing it with verification code, that checks that no ExtractNode is required.

Details

All the relevant cases are marked as "unprofitable" in SuperWord::profitable, see:

jdk/src/hotspot/share/opto/superword.cpp

Lines 1912 to 1915 in dfdd217

	if (!p0->is_Store()) {
	// For now, return false if not all uses are vector.
	// Later, implement ExtractNode and allow non-vector uses (maybe
	// just the ones outside the block.)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8324765: C2 SuperWord: remove dead code: SuperWord::insert_extracts (Sub-task - P4)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer) ⚠️ Review applies to 8a08a4f2
• Christian Hagedorn (@chhagedorn - Reviewer) ⚠️ Review applies to 8a08a4f2

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17589/head:pull/17589
$ git checkout pull/17589

Update a local copy of the PR:
$ git checkout pull/17589
$ git pull https://git.openjdk.org/jdk.git pull/17589/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17589

View PR using the GUI difftool:
$ git pr show -t 17589

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17589.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back epeter! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@eme64 The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (c9fe0153)
• 00: Full (8a08a4f2)

[vnkozlov]

Good.

[openjdk]

@eme64 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324765: C2 SuperWord: remove dead code: SuperWord::insert_extracts

Reviewed-by: kvn, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• 2e748c9: 8175386: Clarify exception behavior of Types utility methods
• 70f4a4e: 8324786: validate-source fails after JDK-8042981
• ed3272c: 8042981: Strip type annotations in Types' utility methods
• 6d18562: 8324785: ProblemList two tests on linux due to JDK-8315923
• 91d8ea7: 8323835: Updating ASM to 9.6 for JDK 23
• a65a895: 8315923: pretouch_memory by atomic-add-0 fragments huge pages unexpectedly
• 62b3293: 8324241: Always record evol_method deps to avoid excessive method flushing
• 885e9b7: 8324722: Serial: Inline block_is_obj of subclasses of Generation
• 32ddcf5: 8324301: Obsolete MaxGCMinorPauseMillis
• c313d45: 8324659: GHA: Generic jtreg errors are not reported

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[chhagedorn]

Looks good!

[eme64]

Thanks for the reviews @vnkozlov @chhagedorn !
/integrate

[openjdk]

Going to push as commit 65d6bc1.
Since your change was applied there have been 11 commits pushed to the master branch:

• 525c0cd: 8324752: C2 Superword: remove SuperWordRTDepCheck
• 2e748c9: 8175386: Clarify exception behavior of Types utility methods
• 70f4a4e: 8324786: validate-source fails after JDK-8042981
• ed3272c: 8042981: Strip type annotations in Types' utility methods
• 6d18562: 8324785: ProblemList two tests on linux due to JDK-8315923
• 91d8ea7: 8323835: Updating ASM to 9.6 for JDK 23
• a65a895: 8315923: pretouch_memory by atomic-add-0 fragments huge pages unexpectedly
• 62b3293: 8324241: Always record evol_method deps to avoid excessive method flushing
• 885e9b7: 8324722: Serial: Inline block_is_obj of subclasses of Generation
• 32ddcf5: 8324301: Obsolete MaxGCMinorPauseMillis
• ... and 1 more: https://git.openjdk.org/jdk/compare/781f368d421a94857929e4168974f43e890637d8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@eme64 Pushed as commit 65d6bc1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.