Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8324769: Serial: Remove unused TenuredGeneration::unsafe_max_alloc_nogc #17591

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Jan 26, 2024

Trivial removing dead code and moving a method from supreclass to subclass.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8324769: Serial: Remove unused TenuredGeneration::unsafe_max_alloc_nogc (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17591/head:pull/17591
$ git checkout pull/17591

Update a local copy of the PR:
$ git checkout pull/17591
$ git pull https://git.openjdk.org/jdk.git pull/17591/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17591

View PR using the GUI difftool:
$ git pr show -t 17591

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17591.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 26, 2024

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8324769 8324769: Serial: Remove unused TenuredGeneration::unsafe_max_alloc_nogc Jan 26, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 26, 2024
@openjdk
Copy link

openjdk bot commented Jan 26, 2024

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jan 26, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 26, 2024

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@openjdk
Copy link

openjdk bot commented Jan 29, 2024

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324769: Serial: Remove unused TenuredGeneration::unsafe_max_alloc_nogc

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 29, 2024
@albertnetymk
Copy link
Member Author

Thanks for review.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 29, 2024

Going to push as commit 4df04f0.
Since your change was applied there have been 20 commits pushed to the master branch:

  • 3066d49: 8317572: C2 SuperWord: refactor/improve TraceSuperWord, replace VectorizeDebugOption with TraceAutoVectorization
  • 7a300b6: 8324213: C1: There is no need for Canonicalizer to handle IfOp
  • 628348d: 8324186: Use "dmb.ishst+dmb.ishld" for release barrier
  • 72ba817: 8324236: compiler/ciReplay/TestInliningProtectionDomain.java failed with RuntimeException: should only dump inline information for ... expected true, was false
  • b39b876: 8324304: RISC-V: add hw probe flags
  • 69586e7: 8322996: BoxLockNode creation fails with assert(reg < CHUNK_SIZE) failed: sanity
  • f0bae79: 8324750: C2: rename Matcher methods using "superword" -> "autovectorization"
  • 6ad78ca: 8324775: C2 SuperWord: refactor visited sets
  • 422020c: 8210858: AArch64: remove Math.log intrinsic
  • 0d5f5e1: 8322484: 22-b26 Regression in J2dBench-bimg_misc-G1 (and more) on Windows-x64 and macOS-x64
  • ... and 10 more: https://git.openjdk.org/jdk/compare/62b3293df0442b06cd00488774db7b608baca774...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 29, 2024
@openjdk openjdk bot closed this Jan 29, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 29, 2024
@openjdk
Copy link

openjdk bot commented Jan 29, 2024

@albertnetymk Pushed as commit 4df04f0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the s1-unsafe branch January 29, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants