8324736: Invalid end positions for EMPTY_STATEMENT

[archiecobbs]

In the fix for JDK-8305671, an EMPTY_STATEMENT representing a lone semicolon was being created with the wrong source code position. The bug was that the starting position needed to be captured prior to advancing to the next token, not after.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8324736: Invalid end positions for EMPTY_STATEMENT (Bug - P4)

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17595/head:pull/17595
$ git checkout pull/17595

Update a local copy of the PR:
$ git checkout pull/17595
$ git pull https://git.openjdk.org/jdk.git pull/17595/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17595

View PR using the GUI difftool:
$ git pr show -t 17595

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17595.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back acobbs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@archiecobbs The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (b09afc89)
• 00: Full (234cfe99)

[bridgekeeper]

@archiecobbs This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[archiecobbs]

/pingbot

[openjdk]

@archiecobbs Unknown command pingbot - for a list of valid commands use /help.

[vicente-romero-oracle]

lgtm

[openjdk]

@archiecobbs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324736: Invalid end positions for EMPTY_STATEMENT

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 306 new commits pushed to the master branch:

• c342188: 8328074: Add jcheck whitespace checking for assembly files
• 3c70f26: 8328112: Remove CardTable::_guard_region
• 48717d6: 8326333: jshell completion on arrays is incomplete
• ece4124: 8328247: Remove redundant dir for tests converted from applet to main
• d32ce65: 8327651: Rename DictionaryEntry members related to protection domain
• 0719419: 8328236: module_entry in CDS map file has stale value
• 0204aac: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
• 9bc1b06: 8328242: Add a log area to the PassFailJFrame
• 65a84c2: 8328006: refactor large anonymous inner class in HtmlDocletWriter
• 044f4ed: 8326979: (jdeps) improve the error message for FindException caused by InvalidModuleDescriptorException
• ... and 296 more: https://git.openjdk.org/jdk/compare/63f6a563a3987d74ef673718d5209cc7c469751c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vicente-romero-oracle) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[archiecobbs]

/integrate

[openjdk]

@archiecobbs
Your change (at version b09afc8) is now ready to be sponsored by a Committer.

[archiecobbs]

@vicente-romero-oracle any interest in sponsoring this so we can wrap it up? Thanks.

[vicente-romero-oracle]

/sponsor

[openjdk]

Going to push as commit 46809b3.
Since your change was applied there have been 387 commits pushed to the master branch:

• f7f291c: 8328301: Convert Applet test ManualHTMLDataFlavorTest.java to main program
• 771f6a2: 8327704: Update nsk/jdi tests to use driver instead of othervm
• 4210e50: 8320362: Load anchor certificates from Keychain keystore
• ab183e4: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main
• ab28045: 8328316: Finisher cannot emit if stream is sequential and integrator returned false
• ba05c6d: 8328368: Convert java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet test to main
• fa823bd: 8328540: test javax/swing/JSplitPane/4885629/bug4885629.java fails on windows hidpi
• e81374e: 8328560: java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports Applet
• cc5cda5: 8328005: Convert java/awt/im/JTextFieldTest.java applet test to main
• ef2bd57: 8328558: Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main
• ... and 377 more: https://git.openjdk.org/jdk/compare/63f6a563a3987d74ef673718d5209cc7c469751c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@vicente-romero-oracle @archiecobbs Pushed as commit 46809b3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.