8324236: compiler/ciReplay/TestInliningProtectionDomain.java failed with RuntimeException: should only dump inline information for ... expected true, was false

[chhagedorn]

The test failed when trying to match the compile id of the interesting method by looking for "<nmethod compile_id='2" in this line:

<nmethod compile_id='2' compiler='c2' entry='0x000000010e293f40' size='680' address='0x000000010e293d90' relocation_offset='360' insts_offset='432' stub_offset='568' scopes_data_offset='616' scopes_pcs_offset='624' dependencies_offset='672' oops_offset='600' metadata_offset='608' method='compiler.ciReplay.ProtectionDomainTestNoOtherCompilationPrivateString test ()V' bytes='5' count='6784' iicount='6784' stamp='0.307'/>

But it first found the earlier line:

<nmethod compile_id='20' compile_kind='c2n' compiler='' entry='0x000000010e28b6c0' size='544' address='0x000000010e28b510' relocation_offset='360' insts_offset='432' method='java.lang.invoke.MethodHandle linkToStatic (ILjava/lang/invoke/MemberName;)Ljava/lang/Object;' bytes='0' count='0' iicount='0' stamp='0.213'/>

which unfortunately also matched "<nmethod compile_id='2". I suggest to make the check stronger by adding a closing ' which should then only match "<nmethod compile_id='2'"

Thanks,
Christian

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8324236: compiler/ciReplay/TestInliningProtectionDomain.java failed with RuntimeException: should only dump inline information for ... expected true, was false (Bug - P4)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17598/head:pull/17598
$ git checkout pull/17598

Update a local copy of the PR:
$ git checkout pull/17598
$ git pull https://git.openjdk.org/jdk.git pull/17598/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17598

View PR using the GUI difftool:
$ git pr show -t 17598

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17598.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back chagedorn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@chhagedorn The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3a2238f9)

[vnkozlov]

Good and trivial.

[openjdk]

@chhagedorn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324236: compiler/ciReplay/TestInliningProtectionDomain.java failed with RuntimeException: should only dump inline information for ... expected true, was false

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 110 new commits pushed to the master branch:

• 70f4a4e: 8324786: validate-source fails after JDK-8042981
• ed3272c: 8042981: Strip type annotations in Types' utility methods
• 6d18562: 8324785: ProblemList two tests on linux due to JDK-8315923
• 91d8ea7: 8323835: Updating ASM to 9.6 for JDK 23
• a65a895: 8315923: pretouch_memory by atomic-add-0 fragments huge pages unexpectedly
• 62b3293: 8324241: Always record evol_method deps to avoid excessive method flushing
• 885e9b7: 8324722: Serial: Inline block_is_obj of subclasses of Generation
• 32ddcf5: 8324301: Obsolete MaxGCMinorPauseMillis
• c313d45: 8324659: GHA: Generic jtreg errors are not reported
• 781f368: 8324347: Enable "maybe-uninitialized" warning for FreeType 2.13.1
• ... and 100 more: https://git.openjdk.org/jdk/compare/b89172149d6a900d11630a95be7278870421b435...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[chhagedorn]

Thanks Vladimir for your review!

/integrate

[openjdk]

Going to push as commit 72ba817.
Since your change was applied there have been 121 commits pushed to the master branch:

• b39b876: 8324304: RISC-V: add hw probe flags
• 69586e7: 8322996: BoxLockNode creation fails with assert(reg < CHUNK_SIZE) failed: sanity
• f0bae79: 8324750: C2: rename Matcher methods using "superword" -> "autovectorization"
• 6ad78ca: 8324775: C2 SuperWord: refactor visited sets
• 422020c: 8210858: AArch64: remove Math.log intrinsic
• 0d5f5e1: 8322484: 22-b26 Regression in J2dBench-bimg_misc-G1 (and more) on Windows-x64 and macOS-x64
• af9cd97: 8324800: gcc windows build broken after 8322757
• 8950d68: 8324753: [AIX] adjust os_posix after JDK-8318696
• 65d6bc1: 8324765: C2 SuperWord: remove dead code: SuperWord::insert_extracts
• 525c0cd: 8324752: C2 Superword: remove SuperWordRTDepCheck
• ... and 111 more: https://git.openjdk.org/jdk/compare/b89172149d6a900d11630a95be7278870421b435...master

Your commit was automatically rebased without conflicts.

[openjdk]

@chhagedorn Pushed as commit 72ba817.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.