Skip to content

8324833: Signed integer overflows in ABS #17617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

8324833: Signed integer overflows in ABS #17617

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5d548e3
Update
shipilev Jan 29, 2024
7d0ea58
Rewrite JVMCI usage to avoid the messy overload
shipilev Jan 30, 2024
f110e39
Merge branch 'master' into JDK-8324833-uabs
shipilev Jan 30, 2024
91d5302
Cleaner version
shipilev Jan 30, 2024
e9333b6
Work
shipilev Jan 30, 2024
d7b951c
Another attempt at JVMCI fix
shipilev Jan 30, 2024
074679a
Also handle the -stride_con with proper uabs
shipilev Jan 30, 2024
00d4d84
Unnecessary comment
shipilev Jan 31, 2024
96a1987
Touchups
shipilev Feb 2, 2024
18dd071
Merge branch 'master' into JDK-8324833-uabs
shipilev Feb 21, 2024
272fb16
Review comments
shipilev Feb 21, 2024
b942242
Fix a place where we cast to jlong after uabs
shipilev Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hotspot/share/opto/loopnode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1107,7 +1107,7 @@ int PhaseIdealLoop::extract_long_range_checks(const IdealLoopTree* loop, jlong s
if (loop->is_range_check_if(if_proj, this, T_LONG, phi, range, offset, scale) &&
loop->is_invariant(range) && loop->is_invariant(offset) &&
original_iters_limit / uabs(scale * stride_con) >= min_iters) {
reduced_iters_limit = MIN2(reduced_iters_limit, original_iters_limit / checked_cast<jlong>(uabs(scale)));
reduced_iters_limit = MIN2(reduced_iters_limit, checked_cast<jlong>(original_iters_limit / uabs(scale)));
range_checks.push(c);
}
}
Expand Down